Verbose State Experience Flags |
||
Issue descriptionOS: Mac Put the security verbose states behind a flag. Flag should have four options: - Show all, animated - Show all, not animated - Show only non-secure, animated - Show only non-secure, not animated
,
Sep 13 2016
To clarify: (1) show all, animated (2) show all, not animated (3) show only "not secure" and "dangerous", animated. hide "secure" and "ev". (4) show only "not secure" and "dangerous", not animated. hide "secure" and "ev"
,
Sep 16 2016
Hey, just wanted to check in -- we should make sure the flags are added before feature freeze (Sept 23) so we can start the review process on-time. Let me know if that doesn't sound ok!
,
Sep 16 2016
Hey, the CL in progress is here: https://codereview.chromium.org/2336423002/ Just got a LGTM, I'm committing it right now. This will be behind the flag "material-security-verbose"
,
Sep 16 2016
Yay, awesome!!
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60196b08a5a39666e08f0416ed53fceeadeef357 commit 60196b08a5a39666e08f0416ed53fceeadeef357 Author: spqchan <spqchan@chromium.org> Date: Fri Sep 16 21:59:04 2016 [Material][Mac] Flag and clean for the Security State Decoration - Refactored LocationBarViewMac so that animations are not called in Layout() - Added flags for the security state decoration BUG= 642977 , 646047 Review-Url: https://codereview.chromium.org/2336423002 Cr-Commit-Position: refs/heads/master@{#419289} [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/app/generated_resources.grd [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/about_flags.cc [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/common/chrome_switches.cc [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/common/chrome_switches.h [modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/tools/metrics/histograms/histograms.xml
,
May 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by spqc...@chromium.org
, Sep 13 2016