New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646047 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Verbose State Experience Flags

Project Member Reported by spqc...@chromium.org, Sep 12 2016

Issue description

OS: Mac

Put the security verbose states behind a flag.
Flag should have four options:
- Show all, animated
- Show all, not animated
- Show only non-secure, animated
- Show only non-secure, not animated
 
Cc: k...@chromium.org emilyschechter@chromium.org est...@chromium.org f...@chromium.org lgar...@chromium.org
To clarify:

(1) show all, animated
(2) show all, not animated
(3) show only "not secure" and "dangerous", animated. hide "secure" and "ev".
(4) show only "not secure" and "dangerous", not animated. hide "secure" and "ev"
Hey, just wanted to check in -- we should make sure the flags are added before feature freeze (Sept 23) so we can start the review process on-time. Let me know if that doesn't sound ok!
Hey, the CL in progress is here: https://codereview.chromium.org/2336423002/

Just got a LGTM, I'm committing it right now. This will be behind the flag "material-security-verbose"
Yay, awesome!!
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60196b08a5a39666e08f0416ed53fceeadeef357

commit 60196b08a5a39666e08f0416ed53fceeadeef357
Author: spqchan <spqchan@chromium.org>
Date: Fri Sep 16 21:59:04 2016

[Material][Mac] Flag and clean for the Security State Decoration

- Refactored LocationBarViewMac so that animations are not called in
Layout()
- Added flags for the security state decoration

BUG= 642977 ,  646047 

Review-Url: https://codereview.chromium.org/2336423002
Cr-Commit-Position: refs/heads/master@{#419289}

[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/app/generated_resources.grd
[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/about_flags.cc
[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h
[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/common/chrome_switches.cc
[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/chrome/common/chrome_switches.h
[modify] https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment