New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646035 link

Starred by 24 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Mac
Pri: 2
Type: Task

Blocked on:
issue 659138

Blocking:
issue 728474
issue 905150



Sign in to add a comment

Shape Detection API (OWP Launch Tracking)

Project Member Reported by mcasas@chromium.org, Sep 12 2016

Issue description

Change description:
Add API for detecting shapes (Faces and/or barcodes) in images.

Changes to API surface:
Add Shape Detection API

Links:
Spec: https://wicg.github.io/shape-detection-api
Public standards discussion: https://discourse.wicg.io/t/rfc-proposal-for-face-detection-api/1642

Support in other browsers:
Internet Explorer: No
Firefox: Public support (https://discourse.wicg.io/t/rfc-proposal-for-face-detection-api/1642/3)
Safari: No

*Make sure to fill in any labels with a -?, including all OSes this change
affects. Feel free to leave other labels at the defaults.

 

Comment 1 by mcasas@chromium.org, Sep 12 2016

Blockedon: 646083

Comment 2 by mcasas@chromium.org, Oct 25 2016

Blockedon: 659138

Comment 3 by mcasas@chromium.org, Oct 25 2016

Blockedon: -646083
Labels: -M-56 M-57

Comment 5 by mcasas@chromium.org, Nov 23 2016

Components: Blink>ImageCapture

Comment 6 by mcasas@chromium.org, Nov 23 2016

Components: -Blink>Image

Comment 7 by mcasas@chromium.org, Nov 23 2016

Labels: ShapeDetection

Comment 8 by mcasas@chromium.org, Jan 10 2017

Labels: -Launch-M-Target-56-Stable Launch-M-Target-58-Stable-Exp

Comment 9 by mcasas@chromium.org, Jan 10 2017

Labels: -M-57 M-58
Cc: rsesek@chromium.org
Labels: -OS-iOS OS-Windows
Based on https://www.chromestatus.com/feature/4757990523535360 is just released on Chrome 57 stable "Behind a flag". Where can I find it in  chrome://flags? It seems not having it.
#11: either "the flag" that enables all interesting stuff:
chrome://flags/#enable-experimental-web-platform-features

or the individual 
--enable-blink-features=ShapeDetection

#12: then https://www.chromestatus.com/feature/4757990523535360 status is wrong. None of https://codepen.io/collection/DwWVJj/ tests works even on Chrome Canary 59.0.3038.0 chrome://flags/#enable-experimental-web-platform-features enables.
Labels: Launch-M-Target-56-Stable-Exp Launch-M-Target-57-Stable-Exp Launch-M-Target-59-Stable
#13: I just tried some on Mac 59.0.3037.0 and most of
them work; plz make sure that you access via https:// 
Also, the code is wired on Mac and Android only ATM, plus:
- Mac QR detection doesn't detect slanted QR codes, not
 barcodes;
- Mac Text detection detects "bubbles" of text, but 
 doesn't decode the text inside.
@mcasas, tested over HTTPS on Win10 64-bit build, all test-cases fails with warnings like "Boo, Text Detection failed: NotSupportedError: Text Detection not implemented.", https://codepen.io/collection/DwWVJj/
#15: only the Mac and Android implementations are wired 
so far. Win10 will be coming soon.
#16: @mcasas, I suggest you update the status in https://www.chromestatus.com/feature/4757990523535360, currently shown "Chrome for desktop release 57" what's understood as supported on Windows desktop.
Labels: -M-58 -Launch-M-Target-56-Stable-Exp -Launch-M-Target-57-Stable-Exp -Launch-M-Target-58-Stable-Exp -Launch-M-Target-59-Stable
Labels: Pri-2
FYI we are aiming to land Shape Detection as an Origin Trial in Chrome 61
Blocking: 728474
This is great. Just tried the API and it works like charm.
Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Cc: -scheib@chromium.org
Is there a target version for this functionality to be available not behind a flag? It would be great to get an idea of when end user's can use this so we can plan our integration. Thanks.
Do we have a target version for this functionality? We would like to start integrating it into our application but it would be helpful to first understand if/when this will be available to all users without a flag. Thanks.
Cc: reillyg@chromium.org
+reillyg@ since he mentioned something about an Origin Trial some time soon.
Owner: reillyg@chromium.org
I will take ownership of launching an Origin Trial for this API soon.
Great news! :)
I cannot find a enable-experimental-web-platform-features flag in Chrome 68 for iOS.I wanna detect barcode in PWA.How can I do it?
funaox@, there is no such flag in Chrome for iOS because it does not use the Blink rendering engine and we therefore cannot add web platform features beyond those supported by Mobile Safari.
Project Member

Comment 33 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/935af3276e04fad6843fd4c35be113043c50ad41

commit 935af3276e04fad6843fd4c35be113043c50ad41
Author: Reilly Grant <reillyg@google.com>
Date: Thu Aug 02 18:33:20 2018

Enable Shape Detection Origin Trial

This change creates an Origin Trial for the Shape Detection API.

Intent to Experiment:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/eJnB-5Sg-mQ/uvdWnO2OBQAJ

Bug: 646035
Change-Id: Ib7b18f8544c0f9d7d4bb8730102800d63cc54c9f
Reviewed-on: https://chromium-review.googlesource.com/1159684
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580259}
[modify] https://crrev.com/935af3276e04fad6843fd4c35be113043c50ad41/third_party/blink/renderer/modules/shapedetection/barcode_detector.idl
[modify] https://crrev.com/935af3276e04fad6843fd4c35be113043c50ad41/third_party/blink/renderer/modules/shapedetection/detected_barcode.idl
[modify] https://crrev.com/935af3276e04fad6843fd4c35be113043c50ad41/third_party/blink/renderer/modules/shapedetection/detected_face.idl
[modify] https://crrev.com/935af3276e04fad6843fd4c35be113043c50ad41/third_party/blink/renderer/modules/shapedetection/detected_text.idl
[modify] https://crrev.com/935af3276e04fad6843fd4c35be113043c50ad41/third_party/blink/renderer/modules/shapedetection/face_detector.idl
[modify] https://crrev.com/935af3276e04fad6843fd4c35be113043c50ad41/third_party/blink/renderer/modules/shapedetection/text_detector.idl
[modify] https://crrev.com/935af3276e04fad6843fd4c35be113043c50ad41/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 34 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/999df0f21c04ad12a3022dc2c345fba5460e2bd9

commit 999df0f21c04ad12a3022dc2c345fba5460e2bd9
Author: Reilly Grant <reillyg@google.com>
Date: Fri Aug 03 15:15:08 2018

Add use counter for the Shape Detection API

This use counter measures calls to the detect() methods provided by the
BarcodeDetector, FaceDetector and TextDetector classes. This is needed
by the Origin Trial infrastructure so that we can measure use of this
API in general rather than use of each detector type individually (which
is covered by the existing use counters).

Bug: 646035
Change-Id: Ic4c70b7e282b0569fad50f273aa9754b0bcb9bbf
Reviewed-on: https://chromium-review.googlesource.com/1161285
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580548}
[modify] https://crrev.com/999df0f21c04ad12a3022dc2c345fba5460e2bd9/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/999df0f21c04ad12a3022dc2c345fba5460e2bd9/third_party/blink/renderer/modules/shapedetection/barcode_detector.idl
[modify] https://crrev.com/999df0f21c04ad12a3022dc2c345fba5460e2bd9/third_party/blink/renderer/modules/shapedetection/face_detector.idl
[modify] https://crrev.com/999df0f21c04ad12a3022dc2c345fba5460e2bd9/third_party/blink/renderer/modules/shapedetection/text_detector.idl
[modify] https://crrev.com/999df0f21c04ad12a3022dc2c345fba5460e2bd9/tools/metrics/histograms/enums.xml

Cc: -foolip@chromium.org
Project Member

Comment 36 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05768b7f5a7fafb8080743522756815da2d9ceff

commit 05768b7f5a7fafb8080743522756815da2d9ceff
Author: junweifu <junwei.fu@intel.com>
Date: Mon Aug 13 15:44:05 2018

ShapeDetection: Remove Shape Detection Register in utility

Shape Detection runs on gpu process, so the Register in utility isn't necessary.

BUG=646035

Change-Id: I3633650f2173ff566ce474f3b35e48658e99f785
Reviewed-on: https://chromium-review.googlesource.com/1170439
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582592}
[modify] https://crrev.com/05768b7f5a7fafb8080743522756815da2d9ceff/content/utility/utility_service_factory.cc

Blocking: 905150
Cc: tsteiner@google.com

Comment 39 by zjlov...@gmail.com, Jan 21 (3 days ago)

Will windows 7 get this API capability? I've done a lot of google search, but I couldn't find the answer.

Sign in to add a comment