blundell@ recently wrote on CL https://chromiumcodereview.appspot.com/2277213003/ "If intended for sharing with iOS, the component will likely need to be made a layered component: https://www.chromium.org/developers/design-documents/layered-components-design"
I think a simple refactoring to split the component into /core/ and /content/ would be a good start toward this goal.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/853ffa852d8c0e27886902a8bdf9149e60c7e8ed commit 853ffa852d8c0e27886902a8bdf9149e60c7e8ed Author: Donn Denman <donnd@chromium.org> Date: Mon Aug 20 21:23:59 2018 [TTS] Refactor the Component to use layered dirs. Refactors the Contextual Search Component to use the layered directory layout recommended for iOS support. This CL splits the top-level directories into /core and /content. A few files that are clearly not dependent on any content have been moved to /core/, and everything else is moved to /content/. There will be some additional /core/ files landing soon. This CL doesn't change any logic or functionality, it just moves source files. BUG= 646019 ,825428 Change-Id: Ia4bf5cdecaabf7d9515b2d4fca855db29b1c4b1c Reviewed-on: https://chromium-review.googlesource.com/1173019 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#584566} [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/android/BUILD.gn [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/browser/BUILD.gn [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/browser/android/contextualsearch/DEPS [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/browser/android/contextualsearch/contextual_search_manager.cc [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/browser/android/contextualsearch/contextual_search_manager.h [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/browser/android/contextualsearch/ctr_suppression.h [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/renderer/BUILD.gn [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/renderer/DEPS [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/BUILD.gn [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/BUILD.gn [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/DEPS [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/browser/contextual_search_js_api_handler.h [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/browser/contextual_search_js_api_service_impl.cc [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/browser/contextual_search_js_api_service_impl.h [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/common/OWNERS [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/common/contextual_search_js_api_service.mojom [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/renderer/DEPS [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/renderer/contextual_search_wrapper.cc [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/renderer/contextual_search_wrapper.h [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/renderer/overlay_js_render_frame_observer.cc [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/content/renderer/overlay_js_render_frame_observer.h [add] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/core/BUILD.gn [add] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/core/DEPS [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/core/browser/ctr_aggregator.cc [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/core/browser/ctr_aggregator.h [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/core/browser/ctr_aggregator_unittest.cc [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/core/browser/weekly_activity_storage.cc [rename] https://crrev.com/853ffa852d8c0e27886902a8bdf9149e60c7e8ed/components/contextual_search/core/browser/weekly_activity_storage.h
Comment 1 by olivierrobin@chromium.org
, Mar 2 2018