New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646010 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 619103



Sign in to add a comment

Under-invalidation paint/selection/text-selection-newline-rtl-double-linebreak.html on Mac and Win

Project Member Reported by wangxianzhu@chromium.org, Sep 12 2016

Issue description

The left part of the selection (covering the br?) changed but is not invalidated.
 
text-selection-newline-rtl-double-linebreak-actual.png
3.7 KB View Download
Blocking: 619103
Status: Available (was: Untriaged)
Owner: wkorman@chromium.org
Status: Assigned (was: Available)
Assigning to wkorman@ because his current work seems related.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e94eda8b670fa91fff645beaa8cce479055e092

commit 3e94eda8b670fa91fff645beaa8cce479055e092
Author: schenney <schenney@chromium.org>
Date: Tue Mar 21 18:02:15 2017

Rebaseline several invalidation tests

These tests may reveal invalidation issues, but right now they are
failing due to changes in font rendering. Rebaseline them
and leave the bugs open in the event invalidation really is
broken (it doesn't seem that way to me).

TBR=wangxianzhu@chromium.org
BUG= 646010 ,646016

Review-Url: https://codereview.chromium.org/2759933006
Cr-Commit-Position: refs/heads/master@{#458469}

[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/paint/invalidation/selected-replaced-expected.txt
[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selected-replaced-expected.png
[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selected-replaced-expected.txt
[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-rtl-double-linebreak-expected.txt
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table-expected.txt
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.png
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.txt
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.txt
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table-expected.txt
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table-expected.txt
[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selected-replaced-expected.png
[delete] https://crrev.com/682ebd314250a8b8597feb5b421958797c33d055/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selected-replaced-expected.txt
[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/mac/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.png
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selected-replaced-expected.png
[delete] https://crrev.com/682ebd314250a8b8597feb5b421958797c33d055/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selected-replaced-expected.txt
[modify] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/win/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.png
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/platform/win7/virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table-expected.txt
[add] https://crrev.com/3e94eda8b670fa91fff645beaa8cce479055e092/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/selected-replaced-expected.txt

Owner: ----
Status: Available (was: Assigned)
Unassigning self from work that I do not expect to be able to get to soon.
Cc: danakj@chromium.org

Comment 7 by danakj@chromium.org, May 16 2017

After https://chromium-review.googlesource.com/c/503472/ this breaks consistently on Linux the same way as on Mac and Win.

Comment 8 by danakj@chromium.org, May 16 2017

This reads like the tests were rebaselined on Windows but my CL also makes them start to fail on windows https://storage.googleapis.com/chromium-layout-test-archives/win_chromium_rel_ng/444875/layout-test-results/results.html so I'm not clear on their state there.

Comment 9 by danakj@chromium.org, May 16 2017

Looking at the baselines in TOT:
- Windows shows no linebreak selection highlight
- Linux shows no linebreak selection highlight
- Mac shows linebreak selection highlight but only on full invalidation

After my CL:
- All platforms show linebreak selection highlight but only on full invalidation
I think the status with your CL is better because it exposes the bug consistently on all platforms. I'm not sure why it's currently platform-dependent. Perhaps the cullRect() hides the bug (and maybe also other under-raster-invalidation bugs) in some platform-dependent way.
Project Member

Comment 11 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f1b6126a7657234b9abc0c4359cbab45850b69

commit c5f1b6126a7657234b9abc0c4359cbab45850b69
Author: danakj <danakj@chromium.org>
Date: Thu May 18 20:38:30 2017

Remove cullRect() from PaintOpBuffer.

Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
methods which is where it is used.

This allows us to more easily get rid of cc::DisplayItem and its
subclasses, replacing them with a PaintOpBuffer in DisplayItemList
directly instead. The difficulty I faced with that was that if
DisplayItemList has a single PaintOpBuffer, then it has a single
cull rect. However when painting, each "batch" of PaintOps can
have a different cull rect (corresponding to the PaintOps that
would have been in a single DisplayItem before). So, instead the
cull rect should be a property of recording at the
RecordPaintCanvas level, which is a temporary object. As such,
creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
need to manage the cull rect themselves to pass to things that
want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
this time).

Original code review was done on gerrit:
https://chromium-review.googlesource.com/c/503472

R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
BUG= 671433 ,  646010 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2889653002 .
Cr-Commit-Position: refs/heads/master@{#472917}

[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/blink/web_display_item_list_impl.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/blink/web_display_item_list_impl.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/layers/picture_image_layer.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/display_item_list.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/drawing_display_item.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/drawing_display_item.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/paint_record.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/paint_record.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/paint_recorder.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/paint_shader.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/paint/record_paint_canvas.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/paint/BoxReflectionUtils.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/BoxReflection.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/LoggingCanvas.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/Pattern.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/Pattern.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/third_party/WebKit/public/platform/WebDisplayItemList.h
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/ui/compositor/paint_recorder.cc
[modify] https://crrev.com/c5f1b6126a7657234b9abc0c4359cbab45850b69/ui/compositor/paint_recorder.h

Project Member

Comment 12 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a007345feeeb92dc19c79ece6806716b831b610

commit 3a007345feeeb92dc19c79ece6806716b831b610
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu May 18 22:20:23 2017

Auto-rebaseline for r472917

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/694561

https://chromium.googlesource.com/chromium/src/+/c5f1b6126a765

BUG= 646010 
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2889683005 .
Cr-Commit-Position: refs/heads/master@{#472950}

[modify] https://crrev.com/3a007345feeeb92dc19c79ece6806716b831b610/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3a007345feeeb92dc19c79ece6806716b831b610/third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/3a007345feeeb92dc19c79ece6806716b831b610/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/3a007345feeeb92dc19c79ece6806716b831b610/third_party/WebKit/LayoutTests/platform/win/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/3a007345feeeb92dc19c79ece6806716b831b610/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png

Project Member

Comment 13 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9

commit ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9
Author: treib <treib@chromium.org>
Date: Fri May 19 12:05:55 2017

Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
>
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
>
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
>
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
>
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG= 671433 ,  646010 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed: https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359cbab45850b69

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 671433 ,  646010 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2894843002
Cr-Commit-Position: refs/heads/master@{#473164}

[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/blink/web_display_item_list_impl.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/blink/web_display_item_list_impl.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/layers/picture_image_layer.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/display_item_list.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/drawing_display_item.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/drawing_display_item.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/paint_record.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/paint_record.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/paint_recorder.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/paint_shader.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/paint/record_paint_canvas.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/paint/BoxReflectionUtils.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/BoxReflection.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/LoggingCanvas.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/Pattern.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/Pattern.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/third_party/WebKit/public/platform/WebDisplayItemList.h
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/ui/compositor/paint_recorder.cc
[modify] https://crrev.com/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9/ui/compositor/paint_recorder.h

Project Member

Comment 14 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/166ac92d870170fd05f1f64cc11d7cd9907d7f1c

commit 166ac92d870170fd05f1f64cc11d7cd9907d7f1c
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri May 19 14:00:33 2017

Auto-rebaseline for r473164

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/695162

https://chromium.googlesource.com/chromium/src/+/ba67e74fd455e

BUG= 646010 
TBR=treib@chromium.org

Review-Url: https://codereview.chromium.org/2889303004 .
Cr-Commit-Position: refs/heads/master@{#473179}

[modify] https://crrev.com/166ac92d870170fd05f1f64cc11d7cd9907d7f1c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/166ac92d870170fd05f1f64cc11d7cd9907d7f1c/third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/166ac92d870170fd05f1f64cc11d7cd9907d7f1c/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/166ac92d870170fd05f1f64cc11d7cd9907d7f1c/third_party/WebKit/LayoutTests/platform/win/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/166ac92d870170fd05f1f64cc11d7cd9907d7f1c/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png

Project Member

Comment 15 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ef12086e6ac7eb83677e7730df00fda5c6af9b

commit 29ef12086e6ac7eb83677e7730df00fda5c6af9b
Author: danakj <danakj@chromium.org>
Date: Tue May 23 18:06:31 2017

Remove cullRect() from PaintOpBuffer.

Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
methods which is where it is used.

This allows us to more easily get rid of cc::DisplayItem and its
subclasses, replacing them with a PaintOpBuffer in DisplayItemList
directly instead. The difficulty I faced with that was that if
DisplayItemList has a single PaintOpBuffer, then it has a single
cull rect. However when painting, each "batch" of PaintOps can
have a different cull rect (corresponding to the PaintOps that
would have been in a single DisplayItem before). So, instead the
cull rect should be a property of recording at the
RecordPaintCanvas level, which is a temporary object. As such,
creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
need to manage the cull rect themselves to pass to things that
want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
this time).

Original code review was done on gerrit:
https://chromium-review.googlesource.com/c/503472

R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
BUG= 671433 ,  646010 ,  724367 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2889653002 .
Cr-Original-Commit-Position: refs/heads/master@{#472917}
Committed: https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359cbab45850b69
Review-Url: https://codereview.chromium.org/2889653002
Cr-Commit-Position: refs/heads/master@{#473975}

[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/blink/web_display_item_list_impl.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/blink/web_display_item_list_impl.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/layers/picture_image_layer.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/display_item_list.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/drawing_display_item.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/drawing_display_item.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_record.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_record.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_recorder.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/paint_shader.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/paint/record_paint_canvas.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/BoxReflectionUtils.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/ClipPathClipper.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/BoxReflection.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/Pattern.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/Pattern.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[add] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/third_party/WebKit/public/platform/WebDisplayItemList.h
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/ui/compositor/paint_recorder.cc
[modify] https://crrev.com/29ef12086e6ac7eb83677e7730df00fda5c6af9b/ui/compositor/paint_recorder.h

Project Member

Comment 16 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aabdc1651e1c112af1c22b41515d93e439215851

commit aabdc1651e1c112af1c22b41515d93e439215851
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue May 23 20:06:47 2017

Auto-rebaseline for r473975

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/699088

https://chromium.googlesource.com/chromium/src/+/29ef12086e6ac

BUG= 646010 
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2902833002 .
Cr-Commit-Position: refs/heads/master@{#474016}

[modify] https://crrev.com/aabdc1651e1c112af1c22b41515d93e439215851/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/aabdc1651e1c112af1c22b41515d93e439215851/third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/aabdc1651e1c112af1c22b41515d93e439215851/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/aabdc1651e1c112af1c22b41515d93e439215851/third_party/WebKit/LayoutTests/platform/win/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png
[modify] https://crrev.com/aabdc1651e1c112af1c22b41515d93e439215851/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak-expected.png

Project Member

Comment 17 by sheriffbot@chromium.org, May 24 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
No sign of missing invalidation now, although it seems to be due to no longer painting some portion of the selection rect.

Sign in to add a comment