New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645996 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 660073
issue 702747

Blocking:
issue 644860
issue 659155
issue 692282



Sign in to add a comment

Ash needs to know about modal windows

Project Member Reported by sky@chromium.org, Sep 12 2016

Issue description

SystemModalContainerLayoutManager needs to know about the modal type, as I suspect other places do to. This should be wired up in WmWindowMus::GetIntProperty for WmWindowProperty::MODAL_TYPE as well as  WmWindowMus::OnWindowSharedPropertyChanged. We'll need mus to communicate this to the wm.
 

Comment 1 by sky@chromium.org, Sep 12 2016

Cc: moh...@chromium.org
Components: MUS
Labels: Proj-Mustash
Components: Internals>MUS

Comment 5 by sky@chromium.org, Jan 4 2017

Blocking: 659155
Components: Internals>Aura
Now that we're using aura this should map to aura::client::kModalKey.

Comment 6 by sky@chromium.org, Feb 13 2017

Labels: -Pri-3 mustash-1 Pri-1

Comment 7 by sky@chromium.org, Feb 13 2017

Blockedon: 660073

Comment 8 by sadrul@chromium.org, Feb 13 2017

Owner: moshayedi@chromium.org
Status: Assigned (was: Untriaged)

Comment 9 by sky@chromium.org, Feb 15 2017

Blocking: 692282
Status: Started (was: Assigned)
Blockedon: 702747
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edab7eb543505b23c3618767d40e2aa4f4ddeb19

commit edab7eb543505b23c3618767d40e2aa4f4ddeb19
Author: moshayedi <moshayedi@chromium.org>
Date: Mon Mar 20 15:15:31 2017

Inform window manager about modal windows in mus+ash.

We need to inform window manager about modal windows. This is necessary because
for example SystemModalContainerLayoutManager needs to know about modal types
so it can create the fullscreen grey background for system modals.

After this change we have some of the WM effects for modal windows (e.g.
animating system modal windows when clicked outside of it), but for
the rest we need more wiring (e.g. no grey background yet) which will
be done in subsequent CLs.

BUG= 645996 

Review-Url: https://codereview.chromium.org/2745143004
Cr-Commit-Position: refs/heads/master@{#458065}

[modify] https://crrev.com/edab7eb543505b23c3618767d40e2aa4f4ddeb19/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/edab7eb543505b23c3618767d40e2aa4f4ddeb19/services/ui/ws/test_utils.cc
[modify] https://crrev.com/edab7eb543505b23c3618767d40e2aa4f4ddeb19/services/ui/ws/test_utils.h
[modify] https://crrev.com/edab7eb543505b23c3618767d40e2aa4f4ddeb19/services/ui/ws/window_tree.cc
[modify] https://crrev.com/edab7eb543505b23c3618767d40e2aa4f4ddeb19/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/edab7eb543505b23c3618767d40e2aa4f4ddeb19/services/ui/ws/window_tree_unittest.cc
[modify] https://crrev.com/edab7eb543505b23c3618767d40e2aa4f4ddeb19/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/edab7eb543505b23c3618767d40e2aa4f4ddeb19/ui/aura/mus/window_tree_client.h

Status: Fixed (was: Started)

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment