Issue metadata
Sign in to add a comment
|
Svg path disappears when CSS filter rule used
Reported by
vsync.de...@gmail.com,
Sep 12 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 53.0.2785.101 m URLs (if applicable) : http://jsbin.com/makukitawa/edit?html,css,output Other browsers tested: Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: Firefox: OK IE: What steps will reproduce the problem? (1) create SVG with path (2) use: path{ filter:blur(1px) } (3) path will completely disappear What is the expected result? svg path should be a little blurry but very visible What happens instead? svg Path disappear Worked well enough on previous Chrome version (Version 52.0.2743.116 m) before I've updated it on my Win7 PC.
,
Sep 16 2016
,
Sep 16 2016
Confirmed. Report indicates it was broken recently. Requesting bisect.
,
Sep 16 2016
,
Sep 16 2016
,
Sep 16 2016
I'm fairly sure (based on the fix) this broke in the unprefixing.
,
Sep 16 2016
And, maybe worth clarifying - this never worked in Chrome (i.e no blur was applied.) That's issue 109224.
,
Sep 16 2016
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05c8461dff1ce44b6bb1d2675492078d332bd209 commit 05c8461dff1ce44b6bb1d2675492078d332bd209 Author: fs <fs@opera.com> Date: Fri Sep 16 20:15:39 2016 Don't treat shorthand filters as errors on SVG content We don't support filter shorthands yet, so we shouldn't treat them as errors. Fix up the hasFilter() condition to also check if it's a filter that we pretend we can handle. Also straighten out the code-flow in applyFilterIfNecessary. BUG= 645995 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2349743003 Cr-Commit-Position: refs/heads/master@{#419267} [modify] https://crrev.com/05c8461dff1ce44b6bb1d2675492078d332bd209/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element-expected.html [modify] https://crrev.com/05c8461dff1ce44b6bb1d2675492078d332bd209/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element.html [modify] https://crrev.com/05c8461dff1ce44b6bb1d2675492078d332bd209/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter-expected.html [modify] https://crrev.com/05c8461dff1ce44b6bb1d2675492078d332bd209/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html [modify] https://crrev.com/05c8461dff1ce44b6bb1d2675492078d332bd209/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp
,
Sep 16 2016
,
Sep 19 2016
,
Sep 19 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fef0448cb827d93c413fce345d37cf02ca9e9702 commit fef0448cb827d93c413fce345d37cf02ca9e9702 Author: Fredrik Söderquist <fs@opera.com> Date: Mon Sep 19 07:58:31 2016 Don't treat shorthand filters as errors on SVG content We don't support filter shorthands yet, so we shouldn't treat them as errors. Fix up the hasFilter() condition to also check if it's a filter that we pretend we can handle. Also straighten out the code-flow in applyFilterIfNecessary. BUG= 645995 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2349743003 Cr-Commit-Position: refs/heads/master@{#419267} (cherry picked from commit 05c8461dff1ce44b6bb1d2675492078d332bd209) Review URL: https://codereview.chromium.org/2354493002 . Cr-Commit-Position: refs/branch-heads/2840@{#407} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element-expected.html [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element.html [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter-expected.html [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp
,
Sep 21 2016
Retested the above issue on All-OS(Windows, Mac 10.11.6 & Ubuntu 14.04) with chrome version '54.0.2840.34' & SVG path is displayed. @fs: Hey, would you mind checking the below screen shot and let us know if this is what is expected result is ? I really appreciate your help. Thank you!
,
Sep 21 2016
Yes, that looks like the expected result.
,
Sep 21 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fef0448cb827d93c413fce345d37cf02ca9e9702 commit fef0448cb827d93c413fce345d37cf02ca9e9702 Author: Fredrik Söderquist <fs@opera.com> Date: Mon Sep 19 07:58:31 2016 Don't treat shorthand filters as errors on SVG content We don't support filter shorthands yet, so we shouldn't treat them as errors. Fix up the hasFilter() condition to also check if it's a filter that we pretend we can handle. Also straighten out the code-flow in applyFilterIfNecessary. BUG= 645995 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2349743003 Cr-Commit-Position: refs/heads/master@{#419267} (cherry picked from commit 05c8461dff1ce44b6bb1d2675492078d332bd209) Review URL: https://codereview.chromium.org/2354493002 . Cr-Commit-Position: refs/branch-heads/2840@{#407} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element-expected.html [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element.html [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter-expected.html [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html [modify] https://crrev.com/fef0448cb827d93c413fce345d37cf02ca9e9702/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by darrentw...@gmail.com
, Sep 15 2016