Issue metadata
Sign in to add a comment
|
3.8%-4.7% regression in thread_times.key_idle_power_cases at 417599:417809 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 12 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9001715932417647376
,
Sep 12 2016
=== Auto-CCing suspected CL author dalecurtis@chromium.org === Hi dalecurtis@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Remove OnSuspend/OnResume notifications on Android. Author : dalecurtis Commit description: These are incorrectly mixing disparate concepts. Chrome code expects OnSuspend/OnResume to mean the system is about to go to sleep, not just that there is no more visible activity. This prevents background tasks like background audio from working properly since the network connections are force killed. We could workaround this by improving when OnSuspend/OnResume is sent, but it seems no one really cares, so just delete these. In fact a couple pieces of code explicitly reject OnSupend/OnResume from Android since they do not mean what is expected. An alternate signal for app suspension should be sent if this is ever needed again in the future. BUG= 644515 TEST=background audio playback works. Review-Url: https://codereview.chromium.org/2324923002 Cr-Commit-Position: refs/heads/master@{#417691} Commit : 610004f26299d1eb31b18f7dce3e2d3740eb8c04 Date : Fri Sep 09 20:29:55 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@417632 170.609 472.149 8 good chromium@417671 3.67206 0.0125903 5 good chromium@417690 3.68112 0.0169794 5 good chromium@417691 3.82264 0.00604186 5 bad <-- chromium@417693 3.83282 0.0138368 5 bad chromium@417695 3.83042 0.0120004 5 bad chromium@417700 3.83011 0.00916674 5 bad chromium@417709 3.82942 0.0121095 8 bad Bisect job ran on: android_s5_perf_bisect Bug ID: 645967 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases Test Metric: tasks_per_second_total_all/set-timeout.html (Long Idle) Relative Change: 98.59% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/994 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001715932417647376 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5795516078620672 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Sep 12 2016
This is expected since we're not shutting down the network connections immediately Anymore. Since this is just a raw count of tasks per second I don't think this is a real issue. cc:Network folk as FYI.
,
Sep 12 2016
SGTM, thanks. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rsch...@chromium.org
, Sep 12 2016