New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645964 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.1%-11.5% regression in memory.top_10_mobile_stress at 417659:417719

Project Member Reported by rsch...@chromium.org, Sep 12 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 13 2016

Cc: mdjones@chromium.org
Owner: mdjones@chromium.org

=== Auto-CCing suspected CL author mdjones@chromium.org ===

Hi mdjones@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Move title creation logic to native
Author  : mdjones
Commit description:
  
This change moves title generation logic to native. This allows titles
to be created as they are needed rather than all at once. The textures
for the title layers are still created by java since they start as
Android views, but this is now triggered by native code.

BUG= 644770 

Review-Url: https://codereview.chromium.org/2320623003
Cr-Commit-Position: refs/heads/master@{#417703}
Commit  : 00a508c5af4957e8986af18e71174352bc212e34
Date    : Fri Sep 09 21:01:20 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@417658  4355358  40846.3  5  good
chromium@417688  4423116  40187.8  8  good
chromium@417696  4390604  59251.2  8  good
chromium@417700  4399718  56425.5  8  good
chromium@417702  4391270  55723.5  8  good
chromium@417703  4796170  120950   5  bad    <--
chromium@417704  4748288  198252   8  bad
chromium@417719  4785152  81960.7  8  bad

Bisect job ran on: android_nexus9_perf_bisect
Bug ID: 645964

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests memory.top_10_mobile_stress
Test Metric: foreground-memory:chrome:all_processes:reported_by_os:system_memory:ashmem:proportional_resident_size_avg/http_en_m_wikipedia_org_wiki_Science
Relative Change: 10.06%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2105
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001716156761632528


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5822877167779840

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Perf sheriff ping
Cc: jasontiller@chromium.org
mdjones@, have you had a chance to look into this regression? 
This change should have improved memory usage as it lazily creates assets instead of doing it all at once. I'll look to see if there is a leak somewhere.
Hey mdjones - any leaks discovered? 
ping
Status: WontFix (was: Assigned)
We just turned down N9s, so we won't be able to bisect this failure anymore. WontFix.
Labels: Performance-Memory

Sign in to add a comment