New issue
Advanced search Search tips

Issue 645953 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug


Sign in to add a comment

Roll clang again

Project Member Reported by thakis@chromium.org, Sep 12 2016

Issue description

Placeholder. The only thing new so far is a plugin change on windows (https://codereview.chromium.org/2318733002)

We probably want to wait until we have some more.
 

Comment 1 by thakis@chromium.org, Sep 12 2016

Blocking: 642812
r281053 brings in a debug info fix

Comment 2 by h...@chromium.org, Sep 12 2016

Blockedon: 645989

Comment 3 by thakis@chromium.org, Sep 13 2016

Blockedon: 646451

Comment 4 by thakis@chromium.org, Sep 13 2016

Blockedon: 646539

Comment 5 by thakis@chromium.org, Sep 13 2016

Intrinsic changes in r281375, r281375

Strictuer about uuids in r281367

Comment 6 by thakis@chromium.org, Sep 13 2016

r281395 inlines fewer dllimport functions

Comment 7 by thakis@chromium.org, Sep 14 2016

Blocking: 645962

Comment 8 by thakis@chromium.org, Sep 14 2016

Some perf regression from the 2-rolls-ago-roll got mysteriously fixed
Blockedon: 648300
Blockedon: 648301
we'll bundle a slightly newer libstdc++ due to https://codereview.chromium.org/2354583004
Blocking: 450379
Blocking: 602649
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4143619d2f58609282b29d102a0c274ffe5910df

commit 4143619d2f58609282b29d102a0c274ffe5910df
Author: thakis <thakis@chromium.org>
Date: Tue Sep 20 15:16:50 2016

Roll clang 280836:281889.

* plugin/win: Use absolute path of source file for filtering
* win: more debug info types
* fix for a perf regression
* win: support for more intrinsics as intrinsics
* win: don't allow duplicate uuid attributes
* win: don't inline implicit ctors, dtors in dllimported classes
* linux: link clang against libstdc++ 4.8.5 instead of 4.8.2
* mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib)

Ran `tools/clang/scripts/upload_revision.py 281889`.

BUG= 645953 
TBR=hans

Review-Url: https://codereview.chromium.org/2349183003
Cr-Commit-Position: refs/heads/master@{#419767}

[modify] https://crrev.com/4143619d2f58609282b29d102a0c274ffe5910df/tools/clang/scripts/update.py

Cc: jgruber@chromium.org
The roll causes a breakage on V8 arm cross-compile debug:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/3144

I was able to repro that locally (also made sure that it fails with the clang update only, also clobbered):
fetch v8
cd v8
git checkout 0ed1254d8
gclient sync
build/linux/sysroot_scripts/install-sysroot.py --arch=arm
tools/dev/v8gen.py -m client.v8.ports -b "V8 Arm - debug builder" arm
ninja -C out.gn/arm -j1000 d8

[1797/1797] LINK ./d8
FAILED: d8 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -pie -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--icf=all -pthread --target=arm-linux-gnueabihf --sysroot=../../build/linux/debian_wheezy_arm-sysroot -L/usr/local/google/home/machenbach/v8/v8/build/linux/debian_wheezy_arm-sysroot/lib/arm-linux-gnueabihf -Wl,-rpath-link=/usr/local/google/home/machenbach/v8/v8/build/linux/debian_wheezy_arm-sysroot/lib/arm-linux-gnueabihf -L/usr/local/google/home/machenbach/v8/v8/build/linux/debian_wheezy_arm-sysroot/usr/lib/arm-linux-gnueabihf -Wl,-rpath-link=/usr/local/google/home/machenbach/v8/v8/build/linux/debian_wheezy_arm-sysroot/usr/lib/arm-linux-gnueabihf -Wl,-rpath-link=. -Wl,--disable-new-dtags -rdynamic -Wl,-O1 -Wl,--gc-sections -o "./d8" -Wl,--start-group @"./d8.rsp"  -Wl,--end-group  -ldl -lrt 
obj/v8_base/bignum.o(.debug_info+0xabf): error: undefined reference to 'v8::internal::Bignum::MultiplyByPowerOfTen(int)::kFive1_to_12'
obj/v8_base/builtins-date.o(.debug_info+0x237): error: undefined reference to 'v8::internal::(anonymous namespace)::MakeDay(double, double, double)::kDayFromMonth'


This only affects the debug build. Any ideas? I reverted our side of the roll in the meantime.
machenbach: That's probably  issue 648800 . Give that build symbol_level=1 or 2, then it'll build faster too.
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c460f170ff1b75bc4f7db11e8b88177b785b18c2

commit c460f170ff1b75bc4f7db11e8b88177b785b18c2
Author: thakis <thakis@chromium.org>
Date: Wed Sep 21 14:56:43 2016

Revert of Roll clang 280836:281889. (patchset #1 id:1 of https://codereview.chromium.org/2349183003/ )

Reason for revert:
Broke android builds, see  https://crbug.com/648800 

Original issue's description:
> Roll clang 280836:281889.
>
> * plugin/win: Use absolute path of source file for filtering
> * win: more debug info types
> * fix for a perf regression
> * win: support for more intrinsics as intrinsics
> * win: don't allow duplicate uuid attributes
> * win: don't inline implicit ctors, dtors in dllimported classes
> * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2
> * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib)
>
> Ran `tools/clang/scripts/upload_revision.py 281889`.
>
> BUG= 645953 
> TBR=hans
>
> Committed: https://crrev.com/4143619d2f58609282b29d102a0c274ffe5910df
> Cr-Commit-Position: refs/heads/master@{#419767}

TBR=hans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 645953 

Review-Url: https://codereview.chromium.org/2361443002
Cr-Commit-Position: refs/heads/master@{#420055}

[modify] https://crrev.com/c460f170ff1b75bc4f7db11e8b88177b785b18c2/tools/clang/scripts/update.py

Blockedon: 648456 648584
Since we need to respin, this is now blocked on more breakage that has accumulated upstream :-(
Blockedon: 648800
Blocking: 643247
Next next next try: https://codereview.chromium.org/2361513002/
Project Member

Comment 25 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b902880cb46202d695e210ccf762365ea0ca1db7

commit b902880cb46202d695e210ccf762365ea0ca1db7
Author: thakis <thakis@chromium.org>
Date: Thu Sep 22 03:25:24 2016

Roll clang 280836:282097.

* plugin/win: Use absolute path of source file for filtering
* win: more debug info types
* fix for a perf regression
* win: support for more intrinsics as intrinsics
* win: don't allow duplicate uuid attributes
* win: don't inline implicit ctors, dtors in dllimported classes
* linux: link clang against libstdc++ 4.8.5 instead of 4.8.2
* mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib)
* android: symbol builds still work (wow!)
* win: MSVC debugger displays correct language in stacks

Ran `tools/clang/scripts/upload_revision.py 282097`.

BUG= 645953 

Review-Url: https://codereview.chromium.org/2361513002
Cr-Commit-Position: refs/heads/master@{#420252}

[modify] https://crrev.com/b902880cb46202d695e210ccf762365ea0ca1db7/tools/clang/scripts/update.py

Owner: thakis@chromium.org
Status: Fixed (was: Untriaged)
Please shout if you still see problems on arm.
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 22 2016

our arm builders are good this time, thanks!

Sign in to add a comment