Locally attached backgrounds with border radius should be able to paint into the scrolling contents layer. |
||||
Issue descriptionWe should be able to paint a locally attached background on an overflow: scroll element with a border radius but they do not paint.
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5e4a2686447be53c5fa482e10190ab568364efe commit a5e4a2686447be53c5fa482e10190ab568364efe Author: flackr <flackr@chromium.org> Date: Mon Sep 12 19:38:36 2016 Don't paint backgrounds with border radius on scrolling contents layer. BUG= 645941 , 645949 TEST=PaintLayerScrollableAreaTest.ShouldPaintBackgroundOntoScrollingContentsLayer CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2333743002 Cr-Commit-Position: refs/heads/master@{#418006} [modify] https://crrev.com/a5e4a2686447be53c5fa482e10190ab568364efe/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp [modify] https://crrev.com/a5e4a2686447be53c5fa482e10190ab568364efe/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
,
Sep 12 2016
🎶🎼😘📗🦁 2016-09-12 19:41 GMT+00:00 bugdro… via monorail < monorail+v2.3275348242@chromium.org>:
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd59f478410b76764e227fe24642bae6f7b06b26 commit dd59f478410b76764e227fe24642bae6f7b06b26 Author: flackr <flackr@chromium.org> Date: Fri Sep 16 01:09:20 2016 Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. BUG= 647169 , 645949 TEST=CompositedLayerMappingTest.BackgroundPaintedIntoGraphicsLayerIfNotCompositedScrolling CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2346883003 Cr-Commit-Position: refs/heads/master@{#419064} [modify] https://crrev.com/dd59f478410b76764e227fe24642bae6f7b06b26/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp [modify] https://crrev.com/dd59f478410b76764e227fe24642bae6f7b06b26/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/dd59f478410b76764e227fe24642bae6f7b06b26/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp [modify] https://crrev.com/dd59f478410b76764e227fe24642bae6f7b06b26/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/dd59f478410b76764e227fe24642bae6f7b06b26/third_party/WebKit/Source/core/paint/PaintLayer.h [modify] https://crrev.com/dd59f478410b76764e227fe24642bae6f7b06b26/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/dd59f478410b76764e227fe24642bae6f7b06b26/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp [modify] https://crrev.com/dd59f478410b76764e227fe24642bae6f7b06b26/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h
,
Sep 16 2016
With this commit the special case to avoid border radius has been removed so the only thing preventing this is just compositing border-radius scrollers: issue 567296 . I have verified a composited local attachment background with border radius works (http://output.jsbin.com/kuleqedule) with https://codereview.chromium.org/544183002 reverted so it is able to paint if/when we composite the scroller.
,
Sep 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a88c6ad9ff6b006f496679107d484df9ca4782c6 commit a88c6ad9ff6b006f496679107d484df9ca4782c6 Author: Robert Flack <flackr@chromium.org> Date: Tue Sep 20 20:59:50 2016 Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. TBR=chrishtr@chromium.org BUG= 647169 , 645949 TEST=CompositedLayerMappingTest.BackgroundPaintedIntoGraphicsLayerIfNotCompositedScrolling CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2346883003 Cr-Commit-Position: refs/heads/master@{#419064} (cherry picked from commit dd59f478410b76764e227fe24642bae6f7b06b26) Review URL: https://codereview.chromium.org/2353623004 . Cr-Commit-Position: refs/branch-heads/2840@{#448} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a88c6ad9ff6b006f496679107d484df9ca4782c6/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/a88c6ad9ff6b006f496679107d484df9ca4782c6/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h [modify] https://crrev.com/a88c6ad9ff6b006f496679107d484df9ca4782c6/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
,
Sep 21 2016
Followed the steps based on the issue - 645941 Verified the fix on Windows 7, MAC (10.11.6) & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 54.0.2840.34 TE-Verified Labels are added. Screen-recording is attached.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a88c6ad9ff6b006f496679107d484df9ca4782c6 commit a88c6ad9ff6b006f496679107d484df9ca4782c6 Author: Robert Flack <flackr@chromium.org> Date: Tue Sep 20 20:59:50 2016 Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. TBR=chrishtr@chromium.org BUG= 647169 , 645949 TEST=CompositedLayerMappingTest.BackgroundPaintedIntoGraphicsLayerIfNotCompositedScrolling CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2346883003 Cr-Commit-Position: refs/heads/master@{#419064} (cherry picked from commit dd59f478410b76764e227fe24642bae6f7b06b26) Review URL: https://codereview.chromium.org/2353623004 . Cr-Commit-Position: refs/branch-heads/2840@{#448} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a88c6ad9ff6b006f496679107d484df9ca4782c6/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/a88c6ad9ff6b006f496679107d484df9ca4782c6/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h [modify] https://crrev.com/a88c6ad9ff6b006f496679107d484df9ca4782c6/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp |
||||
►
Sign in to add a comment |
||||
Comment 1 by schenney@chromium.org
, Sep 12 2016