[Tracking bug] Read Zine variation parameter via feature associations. |
||||||||
Issue descriptionvariations::GetVariationParamValueByFeature() sounds like to cleaner way to read parameters. Some small API changes need to be done: - allow simple changing of parameters associated to features in unit-tests - extend the java variations API with such a method Change the code in ntp_snippets afterwards.
,
Sep 12 2016
,
Sep 13 2016
Good point, I have the lgtm but I can wait a bit :)
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d4ff5f9774061cd48d7941596e2c58cd1b5dbe1 commit 4d4ff5f9774061cd48d7941596e2c58cd1b5dbe1 Author: wjmaclean <wjmaclean@chromium.org> Date: Thu Nov 03 16:59:09 2016 Pass min/max page scale to compositor from WebFrameWidget. Remove a FIXME by plumbing the min/max page scale factor from the WebView into the WebFrameWidget's layerTreeView. This CL is in preparation for plumbing the page scale into the layer tree for subframes, in order that the raster scale can be set properly. The page scale for subframes should remain a 1.f. BUG= 645917 Review-Url: https://codereview.chromium.org/2472133002 Cr-Commit-Position: refs/heads/master@{#429624} [modify] https://crrev.com/4d4ff5f9774061cd48d7941596e2c58cd1b5dbe1/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a6cab73e4df91520c0cbcaacd9ee861dae7805b commit 2a6cab73e4df91520c0cbcaacd9ee861dae7805b Author: wjmaclean <wjmaclean@chromium.org> Date: Thu Nov 03 18:36:40 2016 RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl. In preparation for moving the WeakPtr support from RenderViewImpl to RenderWidget, we change the pointer held by RenderFrameImpl to be a raw pointer instead of a WeakPtr. Since the RenderView should always outlive the RenderFrame, this is safe to do. BUG= 645917 Review-Url: https://codereview.chromium.org/2468423003 Cr-Commit-Position: refs/heads/master@{#429657} [modify] https://crrev.com/2a6cab73e4df91520c0cbcaacd9ee861dae7805b/content/renderer/render_frame_impl.cc [modify] https://crrev.com/2a6cab73e4df91520c0cbcaacd9ee861dae7805b/content/renderer/render_frame_impl.h
,
Nov 7 2016
The above two CLs were linked to the wrong bug, +wjmaclean FYI.
,
Dec 19 2016
This was blocked by 671979. This is now cleared, so I get to it when I find some time for cleaning up (probably not before M57 FF).
,
Jan 30 2017
,
Feb 8 2017
,
Mar 3 2017
,
Jul 24 2017
Done for all important parameters. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by fi...@chromium.org
, Sep 12 2016