New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645917 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocked on:
issue 671979
issue 686778
issue 689937



Sign in to add a comment

[Tracking bug] Read Zine variation parameter via feature associations.

Project Member Reported by jkrcal@chromium.org, Sep 12 2016

Issue description

variations::GetVariationParamValueByFeature() sounds like to cleaner way to read parameters. Some small API changes need to be done:
 - allow simple changing of parameters associated to features in unit-tests
 - extend the java variations API with such a method

Change the code in ntp_snippets afterwards.
 

Comment 1 by fi...@chromium.org, Sep 12 2016

qq: Could this cause problems when we have to merge back some more changes this week? If so, I'd vote for postponing this refactoring by a few days :-)

Comment 2 by fi...@chromium.org, Sep 12 2016

Labels: zine-client-v1 zine-triaged

Comment 3 by jkrcal@chromium.org, Sep 13 2016

Good point, I have the lgtm but I can wait a bit :)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d4ff5f9774061cd48d7941596e2c58cd1b5dbe1

commit 4d4ff5f9774061cd48d7941596e2c58cd1b5dbe1
Author: wjmaclean <wjmaclean@chromium.org>
Date: Thu Nov 03 16:59:09 2016

Pass min/max page scale to compositor from WebFrameWidget.

Remove a FIXME by plumbing the min/max page scale factor from the
WebView into the WebFrameWidget's layerTreeView.

This CL is in preparation for plumbing the page scale into the
layer tree for subframes, in order that the raster scale can be
set properly. The page scale for subframes should remain a 1.f.

BUG= 645917 

Review-Url: https://codereview.chromium.org/2472133002
Cr-Commit-Position: refs/heads/master@{#429624}

[modify] https://crrev.com/4d4ff5f9774061cd48d7941596e2c58cd1b5dbe1/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a6cab73e4df91520c0cbcaacd9ee861dae7805b

commit 2a6cab73e4df91520c0cbcaacd9ee861dae7805b
Author: wjmaclean <wjmaclean@chromium.org>
Date: Thu Nov 03 18:36:40 2016

RenderFrameImpl doesn't need a WeakPtr to RenderViewImpl.

In preparation for moving the WeakPtr support from RenderViewImpl to
RenderWidget, we change the pointer held by RenderFrameImpl to be a
raw pointer instead of a WeakPtr. Since the RenderView should always
outlive the RenderFrame, this is safe to do.

BUG= 645917 

Review-Url: https://codereview.chromium.org/2468423003
Cr-Commit-Position: refs/heads/master@{#429657}

[modify] https://crrev.com/2a6cab73e4df91520c0cbcaacd9ee861dae7805b/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2a6cab73e4df91520c0cbcaacd9ee861dae7805b/content/renderer/render_frame_impl.h

Comment 6 by treib@chromium.org, Nov 7 2016

Cc: wjmaclean@chromium.org
The above two CLs were linked to the wrong bug, +wjmaclean FYI.

Comment 7 by jkrcal@chromium.org, Dec 19 2016

Blockedon: 671979
This was blocked by 671979. This is now cleared, so I get to it when I find some time for cleaning up (probably not before M57 FF).

Comment 8 by jkrcal@chromium.org, Jan 30 2017

Blockedon: 686778
Blockedon: 689937
Cc: -wjmaclean@chromium.org
Summary: [Tracking bug] Read Zine variation parameter via feature associations. (was: Read Zine variation parameter via feature associations.)
Status: Fixed (was: Assigned)
Done for all important parameters.

Sign in to add a comment