New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645909 link

Starred by 2 users
Status: Fixed
Owner:
█ dherkel@google.com
Email to this user bounced
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CSP: Remove some historical metrics.

Project Member Reported by mkwst@chromium.org, Sep 12 2016 
We no longer need `UseCounter::InvalidReportUriDirectiveInMetaCSP`, `UseCounter::InvalidFrameAncestorsDirectiveInMetaCSP`, or `UseCounter::InvalidSandboxDirectiveInMetaCSP`. Let's remove them from `CSPDirectiveList.cpp` and `UseCounter.h`.

Comment 1 by mkwst@chromium.org, Sep 12 2016 

For clarity:

1. Remove these three items from `//src/third_party/WebKit/Source/core/frame/UseCounter.h`.
2. Remove the `UseCounter::count` callsites that use them from `//src/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp`.
3. Remove the corresponding entries from `//src/tools/metrics/histograms/histograms.xml`.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0a3a3721a46a6d003f114622c5d1b590f037fb7

commit b0a3a3721a46a6d003f114622c5d1b590f037fb7
Author: dherkel <dherkel@google.com>
Date: Thu Sep 29 15:00:46 2016

deleted UseCounter usages (InvalidFrameAncestorsDirectiveInMetaCSP, InvalidSandboxDirectiveInMetaCSP, CSPDirectiveList) from UseCounter header file and also removed associated calls to fix  issue 645909 

BUG= 645909 

Review-Url: https://codereview.chromium.org/2370273002
Cr-Commit-Position: refs/heads/master@{#421818}

[modify] https://crrev.com/b0a3a3721a46a6d003f114622c5d1b590f037fb7/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/b0a3a3721a46a6d003f114622c5d1b590f037fb7/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

Comment 3 by dherkel@google.com, Sep 30 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment