Clicking on it closes the bubble.

s/with external extensions/with unsupported external extensions/

This happens constantly on any new profile on a machine that tries to install extensions this way.

https://cs.chromium.org/chromium/src/chrome/browser/extensions/suspicious_extension_bubble_delegate.cc?sq=package:chromium&dr=C&rcl=1478402157&l=93
Return some sort of an empty string, it seems.
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc?sq=package:chromium&dr=C&rcl=1478402157&l=136
Decides whether to show a button according to the emptiness of the string (huh?).

exact same issue here. lmao:

    base::string16
    SuspiciousExtensionBubbleDelegate::GetActionButtonLabel() const {
        return base::string16();
    }

Deleted: extension.png 11.9 KB

	extension.png 11.9 KB View Download

Uh... hmm...

We use the emptiness of the string to determine whether or not to have a button there.  i.e., instead of having
bool ShouldShow() { return false; }
string GetText() { return string(); }
or something we just say
bool should_show = !GetText().empty().

I swear we even have tests for this...

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc?sq=package:chromium

Very strange.

Is there actually a button there?  And this is on Windows?  I'm remote for the rest of this week, but I'll try to investigate soon.

Yes, on Windows, there is a button and clicking on it does the same as the other button (dismisses the bubble).

Tracked this down.

This regressed in revision dc0d234f7c87d29e9d070249a5dd601141faff5b, where we converted the bubble from being programmatically drawn to returning which buttons to show, and assuming that each button had at least an OK button [1].  However, the SuspiciousExtensionMessageBubbleDelegate has a cancel button and no OK button.

This was then fixed in revision 22bc237867193148a4a4e14ac925a41905fff817, which removed the assumption that every bubble had an OK button.

Given this broke way back in M52, is fixed in M56, and M55 is now stable, my guess is that we won't merge this back.  However, I'll leave that up to release managers, as this is a rather silly-looking UI bug.  Note also that if we *do* merge a patch back, it should be only the few lines of revision 22bc237867193148a4a4e14ac925a41905fff817, since that patch is far too large to merge.

[1] https://chromium.googlesource.com/chromium/src/+/dc0d234f7c87d29e9d070249a5dd601141faff5b%5E%21/#F4
[2] https://chromium.googlesource.com/chromium/src/+/dc0d234f7c87d29e9d070249a5dd601141faff5b/chrome/browser/extensions/suspicious_extension_bubble_delegate.cc#95

[Automated comment] Request affecting a post-stable build (M55), manual review required.

As of now there is no plan release for M55. Please request a merge to M56 if needed. Thank you.