New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645901 link

Starred by 2 users
Status: Started
Owner:
█ mkwst@chromium.org
Buried. Ping if important.
Cc:
zcorpan@gmail.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Favicon requests should use image-like `Accept` header values.

Project Member Reported by mkwst@chromium.org, Sep 12 2016 
Requests for images send an `Accept` header of `image/webp,image/*,*/*;q=0.8`. Favicon requests currently send `*/*`, which seems like an oversight.

We should send the same `Accept` header for both.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b4368150456fb577442e83b8a32b8cf3763c33f

commit 8b4368150456fb577442e83b8a32b8cf3763c33f
Author: mkwst <mkwst@chromium.org>
Date: Mon Sep 12 10:32:36 2016

Send an image-like 'Accept' header for favicons.

Requests for images send an `Accept` header of `image/webp,image/*,*/*;q=0.8`.
Favicon requests currently send `*/*`, which seems like an oversight. This
patch aligns the latter with the former.

BUG=645901
R=jochen@chromium.org, japhet@chromium.org

Review-Url: https://codereview.chromium.org/2303443005
Cr-Commit-Position: refs/heads/master@{#417911}

[modify] https://crrev.com/8b4368150456fb577442e83b8a32b8cf3763c33f/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/8b4368150456fb577442e83b8a32b8cf3763c33f/content/browser/loader/mime_sniffing_resource_handler_unittest.cc

Comment 2 by benhenry@google.com, Jan 11 

You started fixing this bug over two years ago. Are you still working on it?
►

Sign in to add a comment