New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645890 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 645091



Sign in to add a comment

Migrate V8 stand-alone to GN (experimental and FYI bots)

Project Member Reported by machenb...@chromium.org, Sep 12 2016

Issue description

Tracker bug.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e33bb1d7cd562d93467a55c0aff7d95769343f8f

commit e33bb1d7cd562d93467a55c0aff7d95769343f8f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Sat Sep 24 12:20:02 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/5c1d87a88517d25aef1d7a4349dc827167d72b1c V8: Remove xcode-ninja bot (machenbach@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=645890

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2367783004
Cr-Commit-Position: refs/heads/master@{#420841}

[modify] https://crrev.com/e33bb1d7cd562d93467a55c0aff7d95769343f8f/infra/config/recipes.cfg

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a8e51a3e6b5c233223bc2135b629853a0eee220a

commit a8e51a3e6b5c233223bc2135b629853a0eee220a
Author: recipe-roller <recipe-roller@chromium.org>
Date: Sat Sep 24 12:50:11 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/5c1d87a88517d25aef1d7a4349dc827167d72b1c V8: Remove xcode-ninja bot (machenbach@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=645890

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2370513003

[modify] https://crrev.com/a8e51a3e6b5c233223bc2135b629853a0eee220a/infra/config/recipes.cfg

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/12d20bdd31b2856e3c6d25dc3388373e7fe6fd00

commit 12d20bdd31b2856e3c6d25dc3388373e7fe6fd00
Author: jochen <jochen@chromium.org>
Date: Thu Jan 05 15:01:30 2017

Add v8_enable_verify_predictable gn args (mirroring the gyp var)

R=machenbach@chromium.org
BUG=chromium:645890

Review-Url: https://codereview.chromium.org/2614983002
Cr-Commit-Position: refs/heads/master@{#42093}

[modify] https://crrev.com/12d20bdd31b2856e3c6d25dc3388373e7fe6fd00/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3cbb2a50c872adec6cf0074821f14d0c29d44f34

commit 3cbb2a50c872adec6cf0074821f14d0c29d44f34
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Mar 23 15:41:34 2017

[build] Switch vtune_jit bot to gn

BUG=chromium:645890
NOTRY=true
TBR=jochen@chromium.org,vogelheim@chromium.org

Change-Id: Id0e972bf2480dd9c48e064537090a7bd97431db1
Reviewed-on: https://chromium-review.googlesource.com/458223
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44066}
[modify] https://crrev.com/3cbb2a50c872adec6cf0074821f14d0c29d44f34/infra/mb/mb_config.pyl

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9bc1eb5ecee0b1859db4baa262c5eff53cfe8b18

commit 9bc1eb5ecee0b1859db4baa262c5eff53cfe8b18
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Mar 23 16:36:08 2017

Enable inspector in gyp

BUG=chromium:645890

Change-Id: Iec8f473074a65abe9b4fbc968d5617038120efa5
Reviewed-on: https://chromium-review.googlesource.com/458011
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44071}
[modify] https://crrev.com/9bc1eb5ecee0b1859db4baa262c5eff53cfe8b18/gypfiles/standalone.gypi
[modify] https://crrev.com/9bc1eb5ecee0b1859db4baa262c5eff53cfe8b18/src/d8.gyp
[modify] https://crrev.com/9bc1eb5ecee0b1859db4baa262c5eff53cfe8b18/src/v8.gyp

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/78ede2b1a3d16c37a6fe5a8ea0b48da633a1c9bf

commit 78ede2b1a3d16c37a6fe5a8ea0b48da633a1c9bf
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Mar 24 08:25:19 2017

[build] Switch predictable bot to gn

BUG=chromium:645890
NOTRY=true
TBR=jochen@chromium.org,vogelheim@chromium.org

Change-Id: I559412b0b85af87494f6d14d0a3b6a016449fc14
Reviewed-on: https://chromium-review.googlesource.com/458657
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44087}
[modify] https://crrev.com/78ede2b1a3d16c37a6fe5a8ea0b48da633a1c9bf/infra/mb/mb_config.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c90ce431617d85a61d5fc07c3ee3bfb15e28be7d

commit c90ce431617d85a61d5fc07c3ee3bfb15e28be7d
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Mar 24 11:14:41 2017

[build] Switch interpreted-regexp bot to gn

Bug: chromium:645890
TBR=yangguo@chromium.org
NOTRY=true

Change-Id: I83bf77a82317c3394d1b81133e52a8b6ecfbe360
Reviewed-on: https://chromium-review.googlesource.com/459418
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44094}
[modify] https://crrev.com/c90ce431617d85a61d5fc07c3ee3bfb15e28be7d/infra/mb/mb_config.pyl

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4482bc2e76d7c68259406021f5fa2d2167a0e70d

commit 4482bc2e76d7c68259406021f5fa2d2167a0e70d
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Mar 24 18:25:08 2017

[test] Run inspector and debugger tests by default

Bug: chromium:645890
TBR=yangguo@chromium.org

Change-Id: Idd884f71278643ce40352a63f436c9072c84c6fd
Reviewed-on: https://chromium-review.googlesource.com/459556
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44118}
[modify] https://crrev.com/4482bc2e76d7c68259406021f5fa2d2167a0e70d/src/d8.gyp
[modify] https://crrev.com/4482bc2e76d7c68259406021f5fa2d2167a0e70d/tools/run-tests.py

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d96fbee9aa35b92afe59179bb02d93566a965d10

commit d96fbee9aa35b92afe59179bb02d93566a965d10
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Apr 05 17:59:07 2017

[build] Remove remaining disable-inspector options in GN

Bug: chromium:645890
Change-Id: I9856712ca8694b3447a611c3555c42145f449b11
Reviewed-on: https://chromium-review.googlesource.com/464726
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44417}
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/BUILD.gn
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/gni/isolate.gni
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/gni/v8.gni
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/gypfiles/isolate.gypi
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/src/d8.cc
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/src/d8.gyp
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/test/BUILD.gn
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/test/debugger/debugger.isolate
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/test/inspector/BUILD.gn
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/test/inspector/inspector.isolate
[modify] https://crrev.com/d96fbee9aa35b92afe59179bb02d93566a965d10/tools/run-tests.py

Comment 14 by a...@chromium.org, Apr 6 2017

Cc: brettw@chromium.org sdefresne@chromium.org
 Issue 709088  has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd6c74121796da3012155a89c16ada1332736a06

commit fd6c74121796da3012155a89c16ada1332736a06
Author: dalecurtis <dalecurtis@chromium.org>
Date: Thu Apr 06 22:28:46 2017

Remove stale gn arg to avoid undeclared argument warning.

v8_enable_inspector was removed recently. Clean up remnants.

Also fixes a dependent gn check issue which blocked submission,
http://crrev.com/462467 did not update GN deps for new header.

BUG=645890, 708965 
TEST=none

Review-Url: https://codereview.chromium.org/2801123002
Cr-Commit-Position: refs/heads/master@{#462652}

[modify] https://crrev.com/fd6c74121796da3012155a89c16ada1332736a06/.gn
[modify] https://crrev.com/fd6c74121796da3012155a89c16ada1332736a06/content/test/BUILD.gn
[modify] https://crrev.com/fd6c74121796da3012155a89c16ada1332736a06/ios/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3291f27bfa76d24c665d7c4cad4d504bbf4454ae

commit 3291f27bfa76d24c665d7c4cad4d504bbf4454ae
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Thu Apr 06 23:13:09 2017

Roll src/third_party/pdfium/ deff61fe7..c758d9dd3 (3 commits)

https://pdfium.googlesource.com/pdfium.git/+log/deff61fe7368..c758d9dd3f94

$ git log deff61fe7..c758d9dd3 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 dalecurtis Remove stale gn arg to avoid undeclared argument warning.
2017-04-06 npm Cleanup CFX_BitmapComposer
2017-04-06 dsinclair Cleanup nits from previous XML Cl

Created with:
  roll-dep src/third_party/pdfium
BUG=645890

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2798063005
Cr-Commit-Position: refs/heads/master@{#462670}

[modify] https://crrev.com/3291f27bfa76d24c665d7c4cad4d504bbf4454ae/DEPS

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1911518736deec53965ca248ca97e4d79cc11425

commit 1911518736deec53965ca248ca97e4d79cc11425
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Jun 21 13:29:36 2017

[build] Switch cfi bot to gn

NOTRY=true

Bug: chromium:645890,chromium:726584
Change-Id: Ie16650d7e8912233407a7f5b2dcb98f917869bdc
Reviewed-on: https://chromium-review.googlesource.com/541319
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46091}
[modify] https://crrev.com/1911518736deec53965ca248ca97e4d79cc11425/infra/mb/mb_config.pyl

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a37f95ff544c051a181a2cbf6023957439f9c806

commit a37f95ff544c051a181a2cbf6023957439f9c806
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Jun 23 07:08:06 2017

[build] Switch more FYI bots to GN

TBR=vogelheim@chromium.org
NOTRY=true

Bug: chromium:645890
Change-Id: Ib5aa315d32c374c2bc755dc67255f84ce544e85f
Reviewed-on: https://chromium-review.googlesource.com/544846
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46155}
[modify] https://crrev.com/a37f95ff544c051a181a2cbf6023957439f9c806/infra/mb/mb_config.pyl

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1ec6671f322280e915a97ceb33bb53680644ef73

commit 1ec6671f322280e915a97ceb33bb53680644ef73
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Jun 26 13:50:28 2017

[build] Add gcov coverage to GN configs

This prepares switching the gcov coverage bot to GN.

We skip instrumenting test executables explicitly in gn configs.
In gyp, we did the same through an extra compiler wrapper script.

NOTRY=true

Bug: chromium:645890
Change-Id: I663fb479347063ae9228598d356bb654ca2a496c
Reviewed-on: https://chromium-review.googlesource.com/548275
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46217}
[modify] https://crrev.com/1ec6671f322280e915a97ceb33bb53680644ef73/BUILD.gn
[modify] https://crrev.com/1ec6671f322280e915a97ceb33bb53680644ef73/gni/v8.gni
[modify] https://crrev.com/1ec6671f322280e915a97ceb33bb53680644ef73/infra/mb/mb_config.pyl

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/095132d67a898225effd51c102c05134b3591077

commit 095132d67a898225effd51c102c05134b3591077
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Jun 27 13:33:56 2017

[build] Switch sanitizer coverage bot to gn

This adds GN configs for using sanitizer coverage and refactors gcov
configs. Now, both coverage kinds are behind the same gn argument
v8_code_coverage.

This also switches the bot to GN.

Bug: chromium:645890,v8:5502
Change-Id: I3af606e0cad109dd790a121d0d92e53cf4e38f9a
Reviewed-on: https://chromium-review.googlesource.com/549360
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46254}
[modify] https://crrev.com/095132d67a898225effd51c102c05134b3591077/BUILD.gn
[modify] https://crrev.com/095132d67a898225effd51c102c05134b3591077/gni/isolate.gni
[modify] https://crrev.com/095132d67a898225effd51c102c05134b3591077/gni/v8.gni
[modify] https://crrev.com/095132d67a898225effd51c102c05134b3591077/infra/mb/mb_config.pyl

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8c38248b956e395bc91d4a4178185a98c55ba271

commit 8c38248b956e395bc91d4a4178185a98c55ba271
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Jun 27 14:17:54 2017

[build] Switch gcov coverage bot to GN

NOTRY=true

Bug: chromium:645890
Change-Id: I40dd42c693aab1c4f8a790e497165f37fe53dcdd
Reviewed-on: https://chromium-review.googlesource.com/548637
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46257}
[modify] https://crrev.com/8c38248b956e395bc91d4a4178185a98c55ba271/infra/mb/mb_config.pyl

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3c41aba2ab409367cabc7d46fbb581e5fd32bcae

commit 3c41aba2ab409367cabc7d46fbb581e5fd32bcae
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Jun 27 14:19:28 2017

[test] Add build_dir option to sancov formatter

This'll make the workflow more flexible as in GN world, the builddir
is often not in the currently hardcoded out/Release.

NOTRY=true

Bug: chromium:645890
Change-Id: Id2afc8d8fea322ac98b65b7e9d28a2ba8c0dd0ac
Reviewed-on: https://chromium-review.googlesource.com/549899
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46258}
[modify] https://crrev.com/3c41aba2ab409367cabc7d46fbb581e5fd32bcae/tools/sanitizers/sancov_formatter.py
[modify] https://crrev.com/3c41aba2ab409367cabc7d46fbb581e5fd32bcae/tools/sanitizers/sancov_formatter_test.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3c41aba2ab409367cabc7d46fbb581e5fd32bcae

commit 3c41aba2ab409367cabc7d46fbb581e5fd32bcae
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Jun 27 14:19:28 2017

[test] Add build_dir option to sancov formatter

This'll make the workflow more flexible as in GN world, the builddir
is often not in the currently hardcoded out/Release.

NOTRY=true

Bug: chromium:645890
Change-Id: Id2afc8d8fea322ac98b65b7e9d28a2ba8c0dd0ac
Reviewed-on: https://chromium-review.googlesource.com/549899
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46258}
[modify] https://crrev.com/3c41aba2ab409367cabc7d46fbb581e5fd32bcae/tools/sanitizers/sancov_formatter.py
[modify] https://crrev.com/3c41aba2ab409367cabc7d46fbb581e5fd32bcae/tools/sanitizers/sancov_formatter_test.py

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/49f71433e631c0cd5f72fda9493383a2683232d6

commit 49f71433e631c0cd5f72fda9493383a2683232d6
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Jun 27 15:40:18 2017

[build] Switch dart builders to GN

NOTRY=true
TBR=whesse@chromium.org

Bug: chromium:645890
Change-Id: I134d8c09792824589430856a1d9b43e0464c4542
Reviewed-on: https://chromium-review.googlesource.com/550159
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46264}
[modify] https://crrev.com/49f71433e631c0cd5f72fda9493383a2683232d6/infra/mb/mb_config.pyl

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7d232d7d6a56da74615a41573087eee8239a9703

commit 7d232d7d6a56da74615a41573087eee8239a9703
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Jun 28 12:01:33 2017

[test] Auto-detect gcov-coverage builds

Bug: chromium:645890
Change-Id: I782934939ab04f63bde8e2f3a7bfef2715fa5e93
Reviewed-on: https://chromium-review.googlesource.com/552127
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46282}
[modify] https://crrev.com/7d232d7d6a56da74615a41573087eee8239a9703/BUILD.gn
[modify] https://crrev.com/7d232d7d6a56da74615a41573087eee8239a9703/tools/run-tests.py

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4234ac9e98705079995e63360d3ee7c83368c95a

commit 4234ac9e98705079995e63360d3ee7c83368c95a
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Jun 28 17:49:26 2017

[build] Fix x87 support in GN configs

Explicitly set gcc as it's derived in gyp.

Bug: chromium:645890
Change-Id: Ibe77ab10b9ce705bdb650b14e212c55b0a9154ba
Reviewed-on: https://chromium-review.googlesource.com/552638
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Zhengxing Li <zhengxing.li@intel.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46295}
[modify] https://crrev.com/4234ac9e98705079995e63360d3ee7c83368c95a/BUILD.gn
[modify] https://crrev.com/4234ac9e98705079995e63360d3ee7c83368c95a/infra/mb/mb_config.pyl

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4234ac9e98705079995e63360d3ee7c83368c95a

commit 4234ac9e98705079995e63360d3ee7c83368c95a
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Jun 28 17:49:26 2017

[build] Fix x87 support in GN configs

Explicitly set gcc as it's derived in gyp.

Bug: chromium:645890
Change-Id: Ibe77ab10b9ce705bdb650b14e212c55b0a9154ba
Reviewed-on: https://chromium-review.googlesource.com/552638
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Zhengxing Li <zhengxing.li@intel.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46295}
[modify] https://crrev.com/4234ac9e98705079995e63360d3ee7c83368c95a/BUILD.gn
[modify] https://crrev.com/4234ac9e98705079995e63360d3ee7c83368c95a/infra/mb/mb_config.pyl

Sign in to add a comment