New issue
Advanced search Search tips

Issue 645887 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 388780



Sign in to add a comment

Should remove DOMMatrix.scaleNonUniformSelf() and DOMMatrix.scaleNonUniform()

Project Member Reported by jinho.b...@samsung.com, Sep 12 2016

Issue description

Should remove DOMMatrix.scaleNonUniformSelf() and DOMMatrix.scaleNonUniform()
 - https://drafts.fxtf.org/geometry/#changes
 

Comment 1 Deleted

Comment 2 Deleted

in my opinion... when remove these function, should be changed implementation about scale and scale3d function in DOMMatrix.
because scale and scale3d function is used scaleNonUniform function.
i'm working in progress (https://codereview.chromium.org/2387003002/)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89064304d942709fa79a51b51e540317f4bb7d9b

commit 89064304d942709fa79a51b51e540317f4bb7d9b
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Sun Oct 16 12:55:45 2016

[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG= 388780 ,  645887 

Review-Url: https://codereview.chromium.org/2387003002
Cr-Commit-Position: refs/heads/master@{#425588}

[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrix.cpp
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrix.h
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrix.idl
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2016

Labels: merge-merged-2892
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89064304d942709fa79a51b51e540317f4bb7d9b

commit 89064304d942709fa79a51b51e540317f4bb7d9b
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Sun Oct 16 12:55:45 2016

[GeometryInterface] remove scaleNonUniform* method.

parameter of scale* method was modified according to spec.
scaleNonUniform* method do not need any more.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scale
https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

BUG= 388780 ,  645887 

Review-Url: https://codereview.chromium.org/2387003002
Cr-Commit-Position: refs/heads/master@{#425588}

[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrix.cpp
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrix.h
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrix.idl
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h
[modify] https://crrev.com/89064304d942709fa79a51b51e540317f4bb7d9b/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl

Cc: hs1217....@samsung.com
Status: Fixed (was: Assigned)

Sign in to add a comment