New issue
Advanced search Search tips

Issue 645884 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 388780



Sign in to add a comment

Should implement DOMMatrix.setMatrixValue().

Project Member Reported by jinho.b...@samsung.com, Sep 12 2016

Issue description

Should implement DOMMatrix.setMatrixValue().
 - https://drafts.fxtf.org/geometry/#dom-dommatrix-setmatrixvalue
 
i'm working in progress(https://codereview.chromium.org/2348083007/) thank you.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b84ec0976538570d0407d95677038679225dd0e

commit 1b84ec0976538570d0407d95677038679225dd0e
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Fri Oct 28 13:23:09 2016

[GeometryInterface] Add setMatrixValue(transfromList) function.

1. if transformList is the empty string,
 set in to the string "matrix(1, 0, 0, 1, 0, 0)".
2. Parse transformList by following the syntax description[1].
 if parsing failed, throw SyntaxError.
3. Set is2D to false if the <transform-list> consists of any 3D
 Transform functions. Otherwise set is2D to true.
4. Transform all <transform-function>s to 4x4 matrices.
5. Post-multiply all matrices from left to right.
6. return the current matrix.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrix-setmatrixvalue
[1] = https://drafts.csswg.org/css-transforms-1/#svg-syntax

BUG= 388780 ,  645884 

Review-Url: https://codereview.chromium.org/2380713004
Cr-Commit-Position: refs/heads/master@{#428352}

[add] https://crrev.com/1b84ec0976538570d0407d95677038679225dd0e/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html
[modify] https://crrev.com/1b84ec0976538570d0407d95677038679225dd0e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1b84ec0976538570d0407d95677038679225dd0e/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp
[modify] https://crrev.com/1b84ec0976538570d0407d95677038679225dd0e/third_party/WebKit/Source/core/css/resolver/TransformBuilder.h
[modify] https://crrev.com/1b84ec0976538570d0407d95677038679225dd0e/third_party/WebKit/Source/core/dom/DOMMatrix.cpp
[modify] https://crrev.com/1b84ec0976538570d0407d95677038679225dd0e/third_party/WebKit/Source/core/dom/DOMMatrix.h
[modify] https://crrev.com/1b84ec0976538570d0407d95677038679225dd0e/third_party/WebKit/Source/core/dom/DOMMatrix.idl

Cc: hs1217....@samsung.com
Status: Fixed (was: Assigned)

Sign in to add a comment