New issue
Advanced search Search tips

Issue 645883 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 388780



Sign in to add a comment

Should implement DOMMatrix.rotateAxisAngleSelf() and DOMMatrixReadOnly.rotateAxisAngle().

Project Member Reported by jinho.b...@samsung.com, Sep 12 2016

Issue description

Should implement DOMMatrix.rotateAxisAngleSelf() and DOMMatrixReadOnly.rotateAxisAngle().
 - https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
 - https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself
 
i'm working in progress(https://codereview.chromium.org/2330463004/)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93612d557c57266bb656d83ceb48469cd13bef03

commit 93612d557c57266bb656d83ceb48469cd13bef03
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Sun Oct 16 10:09:30 2016

[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG= 388780 ,  645883 

Review-Url: https://codereview.chromium.org/2365153002
Cr-Commit-Position: refs/heads/master@{#425585}

[add] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrix.cpp
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrix.h
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrix.idl
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2016

Labels: merge-merged-2892
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93612d557c57266bb656d83ceb48469cd13bef03

commit 93612d557c57266bb656d83ceb48469cd13bef03
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Sun Oct 16 10:09:30 2016

[GeometryInterface] Add rotateAxisAngle*(x,y,z,angle) function.

return a result matrix which rotates on
an axis of given vector(x,y,z) as angle.

spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotateaxisangle
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateaxisangleself

BUG= 388780 ,  645883 

Review-Url: https://codereview.chromium.org/2365153002
Cr-Commit-Position: refs/heads/master@{#425585}

[add] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrix.cpp
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrix.h
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrix.idl
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h
[modify] https://crrev.com/93612d557c57266bb656d83ceb48469cd13bef03/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl

Cc: hs1217....@samsung.com
Status: Fixed (was: Started)

Sign in to add a comment