New issue
Advanced search Search tips

Issue 645882 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 388780



Sign in to add a comment

Should implement DOMMatrix.rotateFromVectorSelf() and DOMMatrixReadOnly.rotateFromVector().

Project Member Reported by jinho.b...@samsung.com, Sep 12 2016

Issue description

Should implement DOMMatrix.rotateFromVectorSelf() and DOMMatrixReadOnly.rotateFromVector().
 - https://drafts.fxtf.org/geometry/#dom-dommatrix-rotatefromvectorself
 - https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotatefromvector
 
Owner: jinho.b...@samsung.com
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66e25541d7b2df4771ad675d96a25ad32f42588f

commit 66e25541d7b2df4771ad675d96a25ad32f42588f
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Tue Oct 25 06:37:44 2016

[GeometryInterface] Add rotate*(), rotateFromVector*() function.

rotate() and rotateSelf() function
1. If rotY and rotZ are both missing,
 set rotZ to the value of rotX and set rotX and rotY to zero.
2. If rotY is still missing, set rotY to zero.
3. If rotZ is still missing, set rotZ to zero.
4. If rotX or rotY are non-zero,
 set is2D of the current matrix to false.
5. Post-multiply a rotation transformation on the current matrix around the vector 0, 0, 1
 by the specified rotation rotZ in degrees.
6. Post-multiply a rotation transformation on the current matrix around the vector 0, 1, 0
 by the specified rotation rotY in degrees.
7. Post-multiply a rotation transformation on the current matrix around the vector 1, 0, 0
 by the specified rotation rotX in degrees.
8. Return the current matrix.

rotateFromVertor() and rotateFromVertorSelf() function
1. Post-multiply a rotation transformation on the current matrix.
 The rotation angle is determined by the angle between the vector (1,0)T and (x,y)T
 in the clockwise direction.
2. Return the current matrix.

spec list:
- https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateself
- https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotate
- https://drafts.fxtf.org/geometry/#dom-dommatrix-rotatefromvectorself
- https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotatefromvector

BUG= 388780 ,  645878 ,  645882 

Review-Url: https://codereview.chromium.org/2444733002
Cr-Commit-Position: refs/heads/master@{#427289}

[modify] https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-rotate.html
[modify] https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f/third_party/WebKit/Source/core/dom/DOMMatrix.cpp
[modify] https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f/third_party/WebKit/Source/core/dom/DOMMatrix.h
[modify] https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f/third_party/WebKit/Source/core/dom/DOMMatrix.idl
[modify] https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h
[modify] https://crrev.com/66e25541d7b2df4771ad675d96a25ad32f42588f/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl

Cc: hs1217....@samsung.com
Status: Fixed (was: Started)

Sign in to add a comment