Issue 645870 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ pihsun@chromium.org Last visit > 30 days ago
Closed:	Nov 2016
Cc:	█ michael....@intel.com █ phoenixshen@chromium.org █ shunhsingou@chromium.org
Components:	Factory
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

factory: Network manager in Goofy is broken

Project Member Reported by hungte@chromium.org, Sep 12 2016

Issue description

Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Set WiFi SSID & PSK in Goofy test list
(2) Reboot

What is the expected output?
Factory SW connected to WLAN

What do you see instead?
Network is not reachable - probably wrong SSID.

This was first reported on http://crosbug.com/p/53062, and also discovered by Earl recently. We believe there's some problem in Goofy network Manager, for WLAN settings.

Comment 1 by hungte@chromium.org, Sep 12 2016

P.S: 53062 is currently marked as fixed, but it's actually trying to re-apply network settings explicitly, which should not be required.

Comment 2 by shunhsingou@google.com, Sep 12 2016

It seems like the dbus interface in flimflam is corrupted in my previous experiments. Flimflam is marked deprecated. May be we should consider rewrite the Network Manager using device API instead of using flimflam.

Comment 3 by hungte@chromium.org, Sep 12 2016

"flimflam" the original implementation is deprecated, but the interface is now provided by "shill". i.e., we should be still able to use it.

If is possible to rewrite network manager, but if the DUT is running ChromeOS, you can't control the network devices without stopping shill (flimflam). And if you stop it, there'll be more problems like (1) some device info can't be probed (2) some device already properly configured may not work (3) some extra device that won't work can't be black-listed (4) you don't have the right order and preference of network interfaces.

In general I still prefer to keep using flimflam(shill) on ChromeOS. Of course, you can make it part of device API and allow boards to decide which implementation (flimflah dbus, or native system calls) to use.

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/74c33c347436ef02faff1ba0ae3aa92d29d6609a

commit 74c33c347436ef02faff1ba0ae3aa92d29d6609a
Author: Peter Shih <pihsun@google.com>
Date: Tue Sep 13 06:26:32 2016

goofy: connection_manager: fix connect to WLAN

When goofy is trying to communicate with shill using dbus-python, and
introspect gives no result about method signature, it would guess the
type to use if no signature is given. For dictionary type, it would
use an arbitrary entry in it, and use its type as the type of all
entries.

Since the org.chromium.flimflam.Manager interface seems to be not
introspectable, and we have both boolean and string as dictionary values,
we need to explicitly specify the signature.

BUG= chromium:645870 
TEST=manual

Change-Id: I123fbd0658b8d4b889eabc093e2e32c25c7c998a
Reviewed-on: https://chromium-review.googlesource.com/384079
Commit-Ready: Pi-hsun Shih <pihsun@google.com>
Tested-by: Pi-hsun Shih <pihsun@google.com>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/74c33c347436ef02faff1ba0ae3aa92d29d6609a/py/goofy/connection_manager.py