New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645865 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocked on:
issue 625847



Sign in to add a comment

Regression:After right clicking on any app it gets open in chrome://apps/

Reported by vku...@etouch.net, Sep 12 2016

Issue description

Chrome Version:  55.0.2858.0 (Official Build)a5e34abf74c2b04f621117773148e0c979fffb7b-refs/heads/master@{#417859} 32/64-bit.
OS:Windows (7,8,8.1,10)

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://apps/
(2)Right click on any app and observe.

Actual: After right clicking on any app it gets open.

Expected: Only context menu should appear after right clicking on any app.

This is a regression issue broken in 'M55' and will soon update other info


 

Comment 1 by vku...@etouch.net, Sep 12 2016

Labels: hasbisect
Owner: nzolghadr@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range
Good Build: 55.0.2853.0
Bad Build:  55.0.2854.2

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/9773f67d88c0f99b27cc5d2d386870322f692892..08557a213c024dbc17f0f8e62aa31e8bae212711?pretty=fuller&n=30

Suspecting: 417053 ?
Kindly help to re-assign, if your changes are not cause for this issue. 

Note:Issue not seen on Mac & Linux OS.
Actual_Apps.mp4
165 KB View Download
Expected_Apps.mp4
174 KB View Download
Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.
Components: Blink>Input
Labels: Hotlist-Input-Dev
Status: Started (was: Assigned)
Blockedon: 625847

Comment 5 by wfh@chromium.org, Sep 16 2016

This is rather frustrating, as it makes it impossible to alter the window opening options of apps on chrome://apps. Is anyone actively working on this?

Comment 6 by wfh@chromium.org, Sep 16 2016

ah there is a workaround for the chrome://apps issue - if you hold down Ctrl while right clicking, then the app will open in a new window, but the context menu appears, so you can change options.
Yup. I am working on it and here it the patch in the review:
https://codereview.chromium.org/2337513002/
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2f7d5c86864715dc770bbc295a68c6ee7297f38

commit c2f7d5c86864715dc770bbc295a68c6ee7297f38
Author: nzolghadr <nzolghadr@chromium.org>
Date: Wed Sep 21 09:05:47 2016

Only handle click actions for left & middle buttons

Change chrome pages to handle actions for left
and middle button click only.

BUG= 645865 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2337513002
Cr-Commit-Position: refs/heads/master@{#420011}

[modify] https://crrev.com/c2f7d5c86864715dc770bbc295a68c6ee7297f38/chrome/browser/resources/history/other_devices.js
[modify] https://crrev.com/c2f7d5c86864715dc770bbc295a68c6ee7297f38/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/c2f7d5c86864715dc770bbc295a68c6ee7297f38/chrome/browser/resources/ntp4/new_tab.js
[modify] https://crrev.com/c2f7d5c86864715dc770bbc295a68c6ee7297f38/ui/webui/resources/js/util.js

Labels: TE-Verified-55.0.2868.0 TE-Verified-M55
Verified the issue on Windows 10 using chrome dev version #55.0.2868.0 as per the comment #0
Observed that the fix is working as expected.

Attaching screencast for reference

Hence, adding the verified labels.
645865.mp4
416 KB View Download

Comment 10 by ajha@chromium.org, Sep 26 2016

Status: Fixed (was: Started)
Regressed in M-55 and the fix has landed and been verified in M-55 hence marking the issue as Fixed.

Please re-open if there is any further work to be done here.

Thank you!
Labels: auxclick

Sign in to add a comment