ChromeScreenshotGrabberTest.TakeScreenshot flaky on Chrome OS |
||||
Issue descriptionThis test is flaky on Chrome OS. https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18006 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18008 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18009 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18010 FindItForMe incorrectly reported https://chromium.googlesource.com/chromium/src/+/68906bba554faf7744b08bc84d31830b4c696c66 as being the faulty CL.
,
Sep 20 2016
Just making a note here. This is related to issue 602485 . My CL (reverted) for fixing that caused this test to fail 100% but the bug also exists on ToT so it's not surprising that this test is flaky. After fixing the failure the test was still flaky but because a DCHECK. That was easily solved by changing the destruction order in SingleThreadProxy. Please see https://codereview.chromium.org/2339633003/ for more details. After the latest fix this test is 100% passing. [4515:4515:0919/162252:955258388925:FATAL:task_runner_provider.h(92)] Check failed: !task_runner_provider_->IsMainThreadBlocked(). #0 0x7f9a0699a00e base::debug::StackTrace::StackTrace() #1 0x7f9a06a003fc logging::LogMessage::~LogMessage() #2 0x7f9a00a28f90 cc::DebugScopedSetMainThreadBlocked::DebugScopedSetMainThreadBlocked() #3 0x7f9a00a3fa21 cc::SingleThreadProxy::DoCommit() #4 0x7f9a00a43d1d cc::SingleThreadProxy::ScheduledActionCommit() #5 0x7f9a008d854c cc::Scheduler::ProcessScheduledActions() #6 0x7f9a008d90b8 cc::Scheduler::DidSwapBuffersComplete() #7 0x7f9a00a42168 cc::SingleThreadProxy::DidSwapBuffersCompleteOnImplThread() #8 0x7f9a009883fa cc::LayerTreeHostImpl::DidSwapBuffersComplete() #9 0x7f99f99f90e2 cc::DirectCompositorFrameSink::DidDrawCallback() #10 0x7f99f99fb03d _ZN4base8internal13FunctorTraitsIMN2cc25DirectCompositorFrameSinkEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_ #11 0x7f99f99faf61 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN2cc25DirectCompositorFrameSinkEFvvEJPS5_EEEvOT_DpOT0_ #12 0x7f99f99faf07 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc25DirectCompositorFrameSinkEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #13 0x7f99f99fae1c _ZN4base8internal7InvokerINS0_9BindStateIMN2cc25DirectCompositorFrameSinkEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #14 0x7f99f9a1c0cb base::internal::RunMixin<>::Run() #15 0x7f99f9a1cce5 cc::Surface::~Surface() #16 0x7f99f9a460bb std::default_delete<>::operator()() #17 0x7f99f9a4602c std::unique_ptr<>::reset() #18 0x7f99f9a44ae9 std::unique_ptr<>::~unique_ptr() #19 0x7f99f9a55285 std::_Destroy<>() #20 0x7f99f9a5524f std::_Destroy_aux<>::__destroy<>() #21 0x7f99f9a5520d std::_Destroy<>() #22 0x7f99f9a551a1 std::_Destroy<>() #23 0x7f99f9a55f23 std::__cxx1998::vector<>::_M_erase_at_end() #24 0x7f99f9a55ed8 std::__cxx1998::vector<>::clear() #25 0x7f99f9a4e54f std::__debug::vector<>::clear() #26 0x7f99f9a4a7cb cc::SurfaceManager::GarbageCollectSurfaces() #27 0x7f99f9a4a1c6 cc::SurfaceManager::Destroy() #28 0x7f99f9a43a77 cc::SurfaceFactory::Destroy() #29 0x7f99f99f8e6b cc::DirectCompositorFrameSink::DetachFromClient() #30 0x7f9a0098d485 cc::LayerTreeHostImpl::ReleaseCompositorFrameSink() #31 0x7f9a00a40a64 cc::SingleThreadProxy::Stop() #32 0x7f9a009b203f cc::LayerTreeHostInProcess::~LayerTreeHostInProcess() #33 0x7f9a009b21a9 cc::LayerTreeHostInProcess::~LayerTreeHostInProcess() #34 0x7f99fd2b327f std::default_delete<>::operator()() #35 0x7f99fd2ab2dc std::unique_ptr<>::reset() #36 0x7f99fd2a7eeb ui::Compositor::~Compositor() #37 0x7f99fd2a82f9 ui::Compositor::~Compositor() #38 0x7f99fd420baf std::default_delete<>::operator()() #39 0x7f99fd41ccbc std::unique_ptr<>::reset() #40 0x7f99fd41b6b0 aura::WindowTreeHost::DestroyCompositor() #41 0x7f99fd4238f7 aura::WindowTreeHostX11::~WindowTreeHostX11() #42 0x7f99fba27b9e ash::AshWindowTreeHostX11::~AshWindowTreeHostX11() #43 0x7f99fba27c49 ash::AshWindowTreeHostX11::~AshWindowTreeHostX11() #44 0x7f99fb735b9f std::default_delete<>::operator()() #45 0x7f99fb9f3b5c std::unique_ptr<>::reset() #46 0x7f99fba3456b ash::RootWindowController::~RootWindowController() #47 0x7f99fba34799 ash::RootWindowController::~RootWindowController() #48 0x7f99fba0834a ash::WindowTreeHostManager::Shutdown() #49 0x7f99fba47625 ash::Shell::~Shell() #50 0x7f99fba48029 ash::Shell::~Shell() #51 0x7f99fba44f3d ash::Shell::DeleteInstance() #52 0x00000874a15f ash::test::AshTestHelper::TearDown() #53 0x000008748c36 ash::test::AshTestBase::TearDown() #54 0x000001a3f5a4 ash::test::ChromeScreenshotGrabberTest::TearDown() #55 0x0000019137ea _ZN7testing8internal12InvokeHelperIN16sync_file_system18RemoteServiceStateESt5tupleIJEEE12InvokeMethodINS2_25MockRemoteFileSyncServiceEMS8_KFS3_vEEES3_PT_T0_RKS5_ #56 0x00000467b78e testing::internal::HandleExceptionsInMethodIfSupported<>() #57 0x000004670bca testing::Test::Run() #58 0x0000046712a8 testing::TestInfo::Run() #59 0x00000467184a testing::TestCase::Run() #60 0x000004676b9c testing::internal::UnitTestImpl::RunAllTests() #61 0x000001d6b7aa _ZN7testing8internal12InvokeHelperIbSt5tupleIJEEE12InvokeMethodI25MockServiceProcessControlMS6_FbvEEEbPT_T0_RKS3_
,
Aug 3 2017
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e0f5df1e114fd76debfbcfcfd0973c9cc8d1dca commit 3e0f5df1e114fd76debfbcfcfd0973c9cc8d1dca Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Aug 21 01:49:30 2017 Add ChromeScreenshotGrabberBrowserTest. After adding screenshot preview in https://crrev.com/c/580178, taken screenshot is decoded in sandboxed process, so it can only be tested by browser test. Also unit test was broken after disabled, but now it is fixed. BUG= 645864 TEST=out/Debug/browser_tests \ '--gtest_filter=ChromeScreenshotGrabberBrowserTest.*' Change-Id: I8839ee5fd8c436319a1fda2373e657d851be6a8c Reviewed-on: https://chromium-review.googlesource.com/620468 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#495860} [modify] https://crrev.com/3e0f5df1e114fd76debfbcfcfd0973c9cc8d1dca/chrome/browser/ui/ash/chrome_screenshot_grabber.cc [modify] https://crrev.com/3e0f5df1e114fd76debfbcfcfd0973c9cc8d1dca/chrome/browser/ui/ash/chrome_screenshot_grabber.h [add] https://crrev.com/3e0f5df1e114fd76debfbcfcfd0973c9cc8d1dca/chrome/browser/ui/ash/chrome_screenshot_grabber_browsertest.cc [delete] https://crrev.com/0c91f5ea705ed829e1ed324e71497a21b2876c32/chrome/browser/ui/ash/chrome_screenshot_grabber_unittest.cc [modify] https://crrev.com/3e0f5df1e114fd76debfbcfcfd0973c9cc8d1dca/chrome/test/BUILD.gn
,
Aug 21 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Sep 12 2016