New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645855 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression: Weird UI of 'View site info' bubble is seen.

Reported by rk...@etouch.net, Sep 12 2016

Issue description

Chrome Version: 55.0.2857.0 Revision f06159b98aa70d663afdc22ea5e8c0ad0ca06bf2-refs/heads/master@{#417845}
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://apps and click on View site info icon.
(2) Observe the spacing on 'View site info' bubble.

Actual: Weird UI of  'View site info' bubble( i.e.spacing between Ok/Cacnel and boarder is not proper) is seen.

Expected: UI of  'View site info' bubble should be proper.

This is regression issue, broken in 'M-55', will soon update the other info

 

Comment 1 by rk...@etouch.net, Sep 12 2016

Labels: hasbisect OS-Linux OS-Mac
Owner: lgar...@chromium.org
Status: Assigned (was: Unconfirmed)
Good build: 55.0.2855.0
Bad Build: 55.0.2857.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/f72e16838524e10980a4e3a99bf1baced0fdf6e2..6d3f5c139eefd9656e8bcc736d88a747086eac0f?pretty=fuller&n=10

Suspecting: r417822
UI.png
32.3 KB View Download
Cc: kavvaru@chromium.org durga.behera@chromium.org brajkumar@chromium.org lgar...@chromium.org ajha@chromium.org
 Issue 645856  has been merged into this issue.
Cc: mea...@chromium.org
Components: Security>UX
Labels: Hotlist-PageInfo
Hmm, this seems like a very unexpected side effect, but it's possible. I'll investigate.
I'm guessing this is due to the removal of GetDialogButtons(), which I assumed referred to the button views added, not buttons at the bottom of the UI.
Labels: ReleaseBlock-Beta
Adding release block label, since this is a recent regression.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f7ed2e5171e67e2220ae844b06a5e8736fa38b5

commit 9f7ed2e5171e67e2220ae844b06a5e8736fa38b5
Author: lgarron <lgarron@chromium.org>
Date: Tue Sep 13 14:16:25 2016

Remove buttons from internal page info bubble.

BUG= 645855 

Review-Url: https://codereview.chromium.org/2330223002
Cr-Commit-Position: refs/heads/master@{#418236}

[modify] https://crrev.com/9f7ed2e5171e67e2220ae844b06a5e8736fa38b5/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Labels: Needs-TestConfirmation
Status: Fixed (was: Assigned)
Components: UI>Browser>Omnibox>PageInfo
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Components: -Security>UX -UI>Browser>Bubbles

Sign in to add a comment