V4L2VDA: processed frame returned after V4L2IP is destroyed |
||||||
Issue descriptionWhen V4L2VideoDecodeAccelerator sends a frame to processor, it uses an extra BindToCurrentLoop. That is not required because the processor is only accessed on the decoder thread. The worse thing is the processed frame may arrive after the processor is destroyed because of the extra hop, which may cause a native crash in V4L2VDA. The fix is to remove the unnecessary BindToCurrentLoop. This only affects oak/elm device.
,
Sep 12 2016
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc85d7601e6932050d2a12d3c03ffb8329969e92 commit cc85d7601e6932050d2a12d3c03ffb8329969e92 Author: wuchengli <wuchengli@chromium.org> Date: Mon Sep 12 09:42:00 2016 V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. When V4L2VideoDecodeAccelerator sends a frame to processor, it uses an extra BindToCurrentLoop. That is not required because the processor is only accessed on the decoder thread. The worse thing is the processed frame may arrive after the processor is destroyed because of the extra hop, which may cause a native crash in V4L2VDA. BUG= 645854 BUG=b/29059119 TEST=Run VDA unittest and video_VideoSeek test. Play video. Review-Url: https://codereview.chromium.org/2329913002 Cr-Commit-Position: refs/heads/master@{#417902} [modify] https://crrev.com/cc85d7601e6932050d2a12d3c03ffb8329969e92/media/gpu/v4l2_video_decode_accelerator.cc
,
Sep 14 2016
This is a one-line fix. It only affects ChromeOS oak/elm devices. I'm requesting a merge to M54.
,
Sep 14 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f48a14aa7d0644df279e2bb332959c2a5e15b912 commit f48a14aa7d0644df279e2bb332959c2a5e15b912 Author: Wu-Cheng Li <wuchengli@chromium.org> Date: Wed Sep 14 08:51:00 2016 V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. When V4L2VideoDecodeAccelerator sends a frame to processor, it uses an extra BindToCurrentLoop. That is not required because the processor is only accessed on the decoder thread. The worse thing is the processed frame may arrive after the processor is destroyed because of the extra hop, which may cause a native crash in V4L2VDA. BUG= 645854 BUG=b/29059119 TEST=Run VDA unittest and video_VideoSeek test. Play video. Review-Url: https://codereview.chromium.org/2329913002 Cr-Commit-Position: refs/heads/master@{#417902} (cherry picked from commit cc85d7601e6932050d2a12d3c03ffb8329969e92) Review URL: https://codereview.chromium.org/2337913004 . Cr-Commit-Position: refs/branch-heads/2840@{#360} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/f48a14aa7d0644df279e2bb332959c2a5e15b912/media/gpu/v4l2_video_decode_accelerator.cc
,
Sep 14 2016
,
Oct 14 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f48a14aa7d0644df279e2bb332959c2a5e15b912 commit f48a14aa7d0644df279e2bb332959c2a5e15b912 Author: Wu-Cheng Li <wuchengli@chromium.org> Date: Wed Sep 14 08:51:00 2016 V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. When V4L2VideoDecodeAccelerator sends a frame to processor, it uses an extra BindToCurrentLoop. That is not required because the processor is only accessed on the decoder thread. The worse thing is the processed frame may arrive after the processor is destroyed because of the extra hop, which may cause a native crash in V4L2VDA. BUG= 645854 BUG=b/29059119 TEST=Run VDA unittest and video_VideoSeek test. Play video. Review-Url: https://codereview.chromium.org/2329913002 Cr-Commit-Position: refs/heads/master@{#417902} (cherry picked from commit cc85d7601e6932050d2a12d3c03ffb8329969e92) Review URL: https://codereview.chromium.org/2337913004 . Cr-Commit-Position: refs/branch-heads/2840@{#360} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/f48a14aa7d0644df279e2bb332959c2a5e15b912/media/gpu/v4l2_video_decode_accelerator.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wuchengli@chromium.org
, Sep 12 2016