New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645842 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

The IME window should support the extended displays

Project Member Reported by shuchen@chromium.org, Sep 12 2016

Issue description

Version: R54
OS: Linux/Windows

What steps will reproduce the problem?
(1) Installs the chrome extension https://chrome.google.com/webstore/detail/google-input-tools/mclkkofklkfljcocdinagocijmpgbhab
(2) Enables Pinyin IME.
(3) Moves the Chrome window to the extended display.
(4) Typing with Pinyin IME in the input field in the Chrome window.

What is the expected output?
The popup IME window (candidate window) stays in the extended display.

What do you see instead?
The popup IME window (candidate window) stayed in the primary display.


 
Components: UI>Input>Text>IME
Status: Started (was: Assigned)
Labels: -Pri-2 -M-55 M-54 Pri-1
Make higher pri as this is pretty annoying for multi display users.

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5f54fe9dfb5a8743b16eba7e85ace45e3d7ef62

commit e5f54fe9dfb5a8743b16eba7e85ace45e3d7ef62
Author: shuchen <shuchen@chromium.org>
Date: Mon Sep 12 10:34:07 2016

Finds the nearest display to show the follow-cursor IME window, instead of  using the primary one.

BUG= 645842 

Review-Url: https://codereview.chromium.org/2335503002
Cr-Commit-Position: refs/heads/master@{#417912}

[modify] https://crrev.com/e5f54fe9dfb5a8743b16eba7e85ace45e3d7ef62/chrome/browser/ui/ime/ime_window.cc

Labels: Merge-Request-54

Comment 5 by dimu@chromium.org, Sep 13 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Labels: TE-Verified-M55 TE-Verified-55.0.2859.0
Verified this issue on windows dual monitor set up using chrome dev version #55.0.2859.0 and observed that the fix is working as expected.

Hence, adding the verified labels.

Note: Could not verify on Linux due to lack of set up.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86d22bd6db66fbeb039a9287afa31b06dade2998

commit 86d22bd6db66fbeb039a9287afa31b06dade2998
Author: Shu Chen <shuchen@google.com>
Date: Wed Sep 14 07:52:00 2016

Finds the nearest display to show the follow-cursor IME window, instead of  using the primary one.

BUG= 645842 

Review-Url: https://codereview.chromium.org/2335503002
Cr-Commit-Position: refs/heads/master@{#417912}
(cherry picked from commit e5f54fe9dfb5a8743b16eba7e85ace45e3d7ef62)

Review URL: https://codereview.chromium.org/2333923005 .

Cr-Commit-Position: refs/branch-heads/2840@{#359}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/86d22bd6db66fbeb039a9287afa31b06dade2998/chrome/browser/ui/ime/ime_window.cc

Status: Fixed (was: Started)
Labels: TE-Verified-54.0.2840.34 TE-Verified-M54
Verified this issue on windows dual monitor set up using chrome beta version #54.0.2840.34 as per the comment #0 and observed that the fix is working as expected.

Attaching screencast for reference

Hence, adding the verified labels.

Note: Could not verify on Linux due to lack of set up.
645842.mp4
3.6 MB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86d22bd6db66fbeb039a9287afa31b06dade2998

commit 86d22bd6db66fbeb039a9287afa31b06dade2998
Author: Shu Chen <shuchen@google.com>
Date: Wed Sep 14 07:52:00 2016

Finds the nearest display to show the follow-cursor IME window, instead of  using the primary one.

BUG= 645842 

Review-Url: https://codereview.chromium.org/2335503002
Cr-Commit-Position: refs/heads/master@{#417912}
(cherry picked from commit e5f54fe9dfb5a8743b16eba7e85ace45e3d7ef62)

Review URL: https://codereview.chromium.org/2333923005 .

Cr-Commit-Position: refs/branch-heads/2840@{#359}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/86d22bd6db66fbeb039a9287afa31b06dade2998/chrome/browser/ui/ime/ime_window.cc

Sign in to add a comment