New issue
Advanced search Search tips

Issue 645841 link

Starred by 2 users
Status: Fixed
Owner:
sunyunjia@chromium.org
Closed: Sep 2016
Cc:
sunyunjia@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Find in page no longer scrolls

Project Member Reported by davidben@chromium.org, Sep 12 2016 
Version: 55.0.2857.0 (Official Build) canary (64-bit)
OS: 10.11.6

What steps will reproduce the problem?
(1) Go to https://certbot.eff.org/docs/using.html
(2) Cmd-f
(3) Type 'the'
(4) Press enter repeatedly

What is the expected output?

The find bar should iterate through results and scroll to each one.

What do you see instead?

It iterates through results, but there's no scrolling.

This works fine in 54.0.2840.16. Reportedly the Dev channel build is also broken, so this appears to be a regression in M55.

Please use labels and text to provide additional information.

Comment 2 by sunyunjia@chromium.org, Sep 12 2016

Owner: sunyunjia@chromium.org
Status: Started (was: Untriaged)

Comment 3 by bokan@chromium.org, Sep 13 2016 

FYI, I merged the offending patch into M54, so the fix here will also have to be merged.

Comment 4 by bokan@chromium.org, Sep 13 2016

Cc: bokan@chromium.org

Comment 5 by davidben@chromium.org, Sep 13 2016

Labels: M-54
(Tagging M-54 so we don't forget.)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57da1c75484e5a3f0af03d038c43e6f23e1549e8

commit 57da1c75484e5a3f0af03d038c43e6f23e1549e8
Author: sunyunjia <sunyunjia@chromium.org>
Date: Fri Sep 16 17:13:17 2016

ScrollRectToVisible should bubble up through its layout container.

Previously, ScrollRectToVisible bubbles up through its dom parent. It works
fine when its layout container is its dom parent, but this is not the case for
absolute-positioned elements. Simply scrolling the dom parent of an
absolute-positioned element wouldn't put the desired rect into view. This patch
changes the behavior by bubbling up through its layout parent.

BUG= 645841 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2336013002
Cr-Commit-Position: refs/heads/master@{#419197}

[add] https://crrev.com/57da1c75484e5a3f0af03d038c43e6f23e1549e8/third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-overflow-clip.html
[modify] https://crrev.com/57da1c75484e5a3f0af03d038c43e6f23e1549e8/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Comment 7 by sunyunjia@chromium.org, Sep 16 2016

Status: Fixed (was: Started)

Comment 8 by davidben@chromium.org, Sep 16 2016 

Does this need to be merged to M54, per comment #3?

Comment 9 by bokan@chromium.org, Sep 17 2016 

No, I reverted the merged patch from the M54 branch because it caused too many regressions. Details are in  issue 437025 .

Comment 10 by dtapu...@chromium.org, Sep 27 2016

Labels: Hotlist-Input-Dev
►

Sign in to add a comment