New issue
Advanced search Search tips

Issue 645820 link

Starred by 1 user
Status: WontFix
Owner:
sdy@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

"Learn more" link on the sad tab becomes selected on right click, but can't be deselected or selected ordinarily

Project Member Reported by sdy@chromium.org, Sep 11 2016 
Version: 55.0.2855.0
OS: macOS 10.11

What steps will reproduce the problem?
(1) Cause a sad tab (chrome://crash)
(2) Right click the "Learn more" link

What is the expected output?
The Open Link and Copy Link context menu items work, but the text doesn't become selected.

What do you see instead?
The text becomes selected and can't be deselected

(26cabf35396e65533b30062b89aee46cbf55b862 was supposed to fix this but broke the Open Link/Copy Link context menu items.)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bb8e10b35b92413ca8c3d4830518089d0f42c70

commit 7bb8e10b35b92413ca8c3d4830518089d0f42c70
Author: sdy <sdy@chromium.org>
Date: Mon Sep 12 02:31:40 2016

Revert a change which broke the "Open/Copy Link" context menu items on the Mac sad tab.

It turns out that these menu items require text to be selectable. A couple
of possible fixes:

- Make the selection color transparent.
- Let the text be selected, but clear the selection when the context
  menu closes.

Partially reverts https://codereview.chromium.org/2261793002.

BUG= 645820 

Review-Url: https://codereview.chromium.org/2330833002
Cr-Commit-Position: refs/heads/master@{#417865}

[modify] https://crrev.com/7bb8e10b35b92413ca8c3d4830518089d0f42c70/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm

Comment 2 by sdy@chromium.org, Feb 23 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment