New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645810 link

Starred by 2 users
Status: Fixed
Owner:
rsesek@chromium.org
Closed: Sep 2016
Cc:
kcc@chromium.org
mbarbe...@chromium.org
infe...@chromium.org
och...@chromium.org
█ aizatsky@chromium.org
mac-bugs-priority@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Broken libFuzzer build on Mac

Project Member Reported by mmoroz@chromium.org, Sep 11 2016 
https://codereview.chromium.org/2325783002/ had broken libFuzzer builds on Mac:

https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan/builds/8489

I have to revert the CL because I don't have an OS X machine to investigate and fix the issue right now.

Sorry for the revert. We are working on adding of a new trybot check to prevent breakages before landing of a new CL.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cb270778f6337af7b5b61e70b9d78d99b2e8877

commit 1cb270778f6337af7b5b61e70b9d78d99b2e8877
Author: mmoroz <mmoroz@chromium.org>
Date: Sun Sep 11 14:40:56 2016

Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ )

Reason for revert:
This CL had broken libFuzzer build for Mac :(
Filed  crbug.com/645810 

Original issue's description:
> Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac.
>
> This also adds the crdmg target after fixing availability warnings.
>
> BUG=none
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
> Cr-Commit-Position: refs/heads/master@{#417725}

TBR=thakis@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 645810 
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2334503002
Cr-Commit-Position: refs/heads/master@{#417860}

[modify] https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877/chrome/utility/BUILD.gn
[delete] https://crrev.com/a5e34abf74c2b04f621117773148e0c979fffb7b/chrome/utility/safe_browsing/mac/BUILD.gn
[modify] https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877/chrome/utility/safe_browsing/mac/crdmg.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8abcd3183b56f96a99155ece7b6e13b56606c11

commit a8abcd3183b56f96a99155ece7b6e13b56606c11
Author: rsesek <rsesek@chromium.org>
Date: Mon Sep 12 23:00:04 2016

Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG= 645810 
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877

Review-Url: https://codereview.chromium.org/2325783002
Cr-Commit-Position: refs/heads/master@{#418091}

[modify] https://crrev.com/a8abcd3183b56f96a99155ece7b6e13b56606c11/chrome/utility/BUILD.gn
[add] https://crrev.com/a8abcd3183b56f96a99155ece7b6e13b56606c11/chrome/utility/safe_browsing/mac/BUILD.gn
[modify] https://crrev.com/a8abcd3183b56f96a99155ece7b6e13b56606c11/chrome/utility/safe_browsing/mac/crdmg.cc

Comment 3 by rsesek@chromium.org, Sep 13 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment