New issue
Advanced search Search tips

Issue 645806 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

AudioContext.createScriptProcessor does not display correct error message

Reported by khoinguy...@gmail.com, Sep 11 2016

Issue description

Example URL:
http://jsbin.com/neqijegaqi/edit?html,js,output

Steps to reproduce the problem:
1. Create an (webkit)AudioContext instance
2. instance.createScriptProcessor(1024,0,33);
3. see log

What is the expected behavior?
Should say: IndexSizeError: Failed to execute 'createScriptProcessor' on 'AudioContext': number of output channels (33) exceeds maximum (32).

What went wrong?
Got: IndexSizeError: Failed to execute 'createScriptProcessor' on 'AudioContext': number of output channels (0) exceeds maximum (32).

Did this work before? N/A 

Is it a problem with Flash or HTML5? HTML5

Does this work in other browsers? Yes 

Chrome version: 53.0.2785.86  Channel: stable
OS Version: 9.3.5
Flash Version: --

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp?q=%22number+of+output+channels%22&sq=package:chromium&dr=C&l=383

https://github.com/crosswalk-project/blink-crosswalk/blob/master/Source/modules/webaudio/AudioContext.cpp#L421

*Please put this to Blink>WebAudio
*ScriptProcessorNode is deprecating.
 
Windows 10 (newest Chrome) gave me those message, by the way. On my iPad (iOS 9.3.5), Chrome version above, the error is just: IndexSizeError: DOM Exception 1
Components: -Internals>Media Blink>WebAudio
Probably needs to be reported to Apple, but +webaudio folk.

Comment 3 by rtoy@chromium.org, Sep 12 2016

Status: Available (was: Unconfirmed)
Yeah, a typo in chromium code.

For the message on your ipad, that's a webkit issue and should be reported there.

Comment 4 by rtoy@chromium.org, Sep 12 2016

Labels: -OS-iOS OS-All

Comment 5 by rtoy@chromium.org, Sep 12 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
๐Ÿ“น๐Ÿฑ๐Ÿ›…๐Ÿณ๐Ÿšผ

2016-09-12 18:24 GMT+00:00 rโ€ฆ via monorail <
monorail+v2.2158573027@chromium.org>:
Oh cool. Thanks! :) Today I learn Chrome is under Blink now. 
๐ŸŒ๐Ÿ˜˜๐ŸŽผ

2016-09-12 19:59 GMT+00:00 khoinguyโ€ฆ via monorail <
monorail+v2.4014460122@chromium.org>:
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5196ddbea6597d66d839cb25f7acee9855491bc0

commit 5196ddbea6597d66d839cb25f7acee9855491bc0
Author: rtoy <rtoy@chromium.org>
Date: Mon Sep 12 22:04:52 2016

Fix incorrect error message for ScriptProcessorNode

The value printed when the number of output channels exceeded the
maximum value was incorrectly printing the number of input channels.

The test correctly checked this, but the expected result was
incorrectly checking for the incorrect value.

BUG= 645806 
TEST=dom-exceptions.html updated expectations

Review-Url: https://codereview.chromium.org/2332043002
Cr-Commit-Position: refs/heads/master@{#418071}

[modify] https://crrev.com/5196ddbea6597d66d839cb25f7acee9855491bc0/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/5196ddbea6597d66d839cb25f7acee9855491bc0/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp

Comment 10 by rtoy@chromium.org, Sep 14 2016

Status: Fixed (was: Started)

Sign in to add a comment