"PolicyTest.DisableScreenshotsFile" is flaky |
||||||||||
Issue description"PolicyTest.DisableScreenshotsFile" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFQb2xpY3lUZXN0LkRpc2FibGVTY3JlZW5zaG90c0ZpbGUM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 12 2016
Disabling in https://codereview.chromium.org/2332683002/ bartfab: Please have a look.
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2c07745c48c3d1521ade535d6d853926ced1610 commit d2c07745c48c3d1521ade535d6d853926ced1610 Author: kjellander <kjellander@chromium.org> Date: Mon Sep 12 07:59:57 2016 Disable PolicyTest.DisableScreenshotsFile test due to being flaky. BUG=645769 TBR=bartfab@chromium.org Review-Url: https://codereview.chromium.org/2332683002 Cr-Commit-Position: refs/heads/master@{#417891} [modify] https://crrev.com/d2c07745c48c3d1521ade535d6d853926ced1610/chrome/browser/policy/policy_browsertest.cc
,
Sep 12 2016
Detected 11 new flakes for test/step "PolicyTest.DisableScreenshotsFile". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFQb2xpY3lUZXN0LkRpc2FibGVTY3JlZW5zaG90c0ZpbGUM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Sep 13 2016
Last flaked (#417889) before the revert (#417891), so this should go out of sheriff queue.
,
Jun 27 2017
I noticed this while doing a TaskScheduler conversion in ChromeScreenshotGrabber.
There's some odd code in this test:
class QuitMessageLoopAfterScreenshot : public ui::ScreenshotGrabberObserver {
public:
void OnScreenshotCompleted(
ScreenshotGrabberObserver::Result screenshot_result,
const base::FilePath& screenshot_path) override {
BrowserThread::PostTaskAndReply(BrowserThread::IO, FROM_HERE,
base::Bind(base::DoNothing),
base::MessageLoop::QuitWhenIdleClosure());
}
~QuitMessageLoopAfterScreenshot() override {}
};
It's not clear to me why it needs to ping the IO thread. I wonder if it needs to ping the blocking pool / sequenced task runner (to make sure all its tasks are done).
Or it might be flaky because it is counting files in the downloads directory.
,
Jun 28 2017
Dropping into the enterprise triage queue.
,
Jun 28 2017
,
Jun 29 2017
Hey Julien, do you know who I can assign this to?
,
Jun 29 2017
,
Jun 29 2017
Well someone on your team working on ChromeOS it seems. It is a ChromeOS specific issue.
,
Jul 5 2017
,
Jul 5
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, Sep 11 2016