New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645755 link

Starred by 6 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Sep 2016
Cc:
█ shrike@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Tab label descenders are clipped

Reported by davidj...@gmail.com, Sep 10 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.101 Safari/537.36

Steps to reproduce the problem:
1. Open a page such as https://www.google.co.uk
2. Look at the tab

What is the expected behavior?
Tab label is displayed fully

What went wrong?
Descenders (g, p, etc.) are clipped. It looks as though the entire font is shifted down by 1 or 2 pixels compared to its usual vertically-centred alignment.

Did this work before? Yes Until very recently; possibly broken within past day or so

Chrome version: 53.0.2785.101  Channel: stable
OS Version: OS X 10.11.6
Flash Version: 

This is on a retina display; other display resolutions untested.
ChromeBug.png
50.1 KB View Download

Comment 1 by l...@yearbookmachine.com, Sep 12 2016 

This issue is only visible when the new material design UI is disabled using the following flag:

chrome://flags/#top-chrome-md

With Top Chrome MD set to default/enabled the descenders are visible.
Screen Shot 2016-09-12 at 10.24.56.png
7.3 KB View Download

Comment 2 by ellyjo...@chromium.org, Sep 13 2016

Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
I reproduced this issue locally. shrike@, any ideas? You know the tab-drawing code well.

Comment 3 by shrike@chromium.org, Sep 13 2016

Cc: shrike@chromium.org
Components: -UI UI>Browser>TabStrip
Owner: ellyjo...@chromium.org
Not sure. Sounds like a recent cl changed something - you could manually bisect to track down.

We don't support pre-MD UI, so in some sense this bug need not be fixed. We should at least find the cl that changed things.

Comment 4 by ellyjo...@chromium.org, Sep 14 2016 

 Issue 646692  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/235ec06ba2318c7656bf40efdfa385cf68b2b92d

commit 235ec06ba2318c7656bf40efdfa385cf68b2b92d
Author: ellyjones <ellyjones@chromium.org>
Date: Mon Sep 19 15:30:59 2016

cocoa browser: don't make non-MD tab titles smaller

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG= 645755 

Review-Url: https://codereview.chromium.org/2346513006
Cr-Commit-Position: refs/heads/master@{#419465}

[modify] https://crrev.com/235ec06ba2318c7656bf40efdfa385cf68b2b92d/chrome/browser/ui/cocoa/tabs/tab_controller.mm

Comment 6 by ellyjo...@chromium.org, Sep 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment