[css-grid] When using the repeat notation and auto-fit, grid-gaps are not collapsing to 0
Reported by
rachelan...@gmail.com,
Sep 10 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2856.0 Safari/537.36 Example URL: http://codepen.io/rachelandrew/details/dpYzkq/ Steps to reproduce the problem: Create a grid definition: .cont { display: grid; grid-gap: 10px; grid-template-columns: repeat(auto-fit, minmax(200px,1fr)); } Auto place three child items and ensure the container is wide enough to cause collapsing of tracks. What is the expected behavior? Gaps should collapse to 0 in the same manner as tracks. What went wrong? Get what appears to be a gap sized space at the end of the row. Does it occur on multiple sites: No Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? Yes Chrome version: 55.0.2856.0 Channel: canary OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 23.0 r0 This seems to work correctly in Firefox Nightlies.
,
Sep 12 2016
Thanks for the report Rachel, it seems we've an extra gap there. Probably @svillar can investigate it. @rnimmagadda you need to enable the experimental flag to test Grid Layout (--enable-experimental-web-platform-features).
,
Sep 12 2016
,
Sep 12 2016
Checking
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/011d6fa1bdaa3f942a389ae3b55d20f681c63bbf commit 011d6fa1bdaa3f942a389ae3b55d20f681c63bbf Author: svillar <svillar@igalia.com> Date: Tue Sep 13 09:53:19 2016 [css-grid] Too many gaps with trailing collapsing tracks The total size of gaps were incorrectly computed whenever there were trailing collapsed tracks (with collapsed gaps). The problem was that we were trying to optimize too much the amount of hash table queries required to know the gaps between two lines. We were considering that a gap always exist between 2 consecutive tracks if the first one is not empty. That's generally true (for both NOTEMPTY - NOTEMPTY and NOTEMPTY - EMPTY+ - NOTEMPTY sequences) but not for all the cases (NOTEMPTY - EMPTY+). BUG= 645746 Review-Url: https://codereview.chromium.org/2336663002 Cr-Commit-Position: refs/heads/master@{#418209} [modify] https://crrev.com/011d6fa1bdaa3f942a389ae3b55d20f681c63bbf/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fit-columns.html [modify] https://crrev.com/011d6fa1bdaa3f942a389ae3b55d20f681c63bbf/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
,
Sep 13 2016
Fixed! |
||||
►
Sign in to add a comment |
||||
Comment 1 by rnimmagadda@chromium.org
, Sep 12 2016Components: Blink>Layout>Grid
Labels: -Type-Compat M-53 OS-Linux OS-Windows Type-Bug
Status: Untriaged (was: Unconfirmed)
1.1 MB
1.1 MB View Download