`git cl upload` in chromium/src taking 6 minutes in presubmit check |
||||||
Issue descriptionChrome 55.0.2853.0 OSX 10.11.6 This is a top-of-the-line Macbook Pro with 16GB RAM and running no other significant workload. What steps will reproduce the problem? (1) Upload patch of https://codereview.chromium.org/2329153002 What is the expected output? Reasonable runtime. What do you see instead? lgarron@lgarron-macbookpro ~/c/src (remove-warning)> git cl upload HEAD~ Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit upload checks ... Include Blink enums. git cl try checking owners took a long time: 28586ms Done processing /Users/lgarron/chromium/src/chrome/browser/android/policy/policy_auditor.cc Done processing /Users/lgarron/chromium/src/chrome/browser/ssl/chrome_security_state_model_client.cc checking owners took a long time: 28718ms ** Presubmit Messages ** Missing OWNER reviewers for these files: chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java chrome/browser/android/policy/policy_auditor.cc chrome/browser/ssl/chrome_security_state_model_client.cc chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm components/security_state/security_state_model.cc components/security_state/security_state_model.h components/toolbar/toolbar_model_impl.cc content/browser/devtools/protocol/security_handler.cc content/child/web_url_loader_impl.cc content/public/common/security_style.h ios/chrome/browser/ssl/ios_chrome_security_state_model_client.mm ios/web/net/request_tracker_impl.mm ios/web/public/security_style.h third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp third_party/WebKit/Source/core/inspector/browser_protocol.json third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js third_party/WebKit/Source/platform/network/ResourceResponse.h third_party/WebKit/public/platform/WebURLResponse.h Suggested OWNERS: (Use "git-cl owners" to interactively select owners.) avi@chromium.org felt@chromium.org mariakhomenko@chromium.org eugenebut@chromium.org pkasting@chromium.org changwan@chromium.org pfeldman@chromium.org Missing OWNER reviewers for these files: chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java chrome/browser/android/policy/policy_auditor.cc chrome/browser/ssl/chrome_security_state_model_client.cc chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm components/security_state/security_state_model.cc components/security_state/security_state_model.h components/toolbar/toolbar_model_impl.cc content/browser/devtools/protocol/security_handler.cc content/child/web_url_loader_impl.cc content/public/common/security_style.h ios/chrome/browser/ssl/ios_chrome_security_state_model_client.mm ios/web/net/request_tracker_impl.mm ios/web/public/security_style.h third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp third_party/WebKit/Source/core/inspector/browser_protocol.json third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js third_party/WebKit/Source/platform/network/ResourceResponse.h third_party/WebKit/public/platform/WebURLResponse.h Suggested OWNERS: (Use "git-cl owners" to interactively select owners.) avi@chromium.org felt@chromium.org mlamouri@chromium.org eugenebut@chromium.org tedchoc@chromium.org pkasting@chromium.org pfeldman@chromium.org Presubmit checks took 304.3s to calculate. Presubmit checks passed. chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java | 1 - chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java | 2 -- chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java | 2 -- chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java | 1 - chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java | 1 - chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java | 3 +-- chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java | 3 +-- chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java | 6 +++--- chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java | 1 - chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java | 8 +++----- chrome/browser/android/policy/policy_auditor.cc | 1 - chrome/browser/ssl/chrome_security_state_model_client.cc | 8 +------- chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm | 12 ++---------- components/security_state/security_state_model.cc | 7 ------- components/security_state/security_state_model.h | 3 --- components/toolbar/toolbar_model_impl.cc | 6 ------ content/browser/devtools/protocol/security_handler.cc | 2 -- content/child/web_url_loader_impl.cc | 3 --- content/public/common/security_style.h | 5 ----- ios/chrome/browser/ssl/ios_chrome_security_state_model_client.mm | 4 ---- ios/web/net/request_tracker_impl.mm | 3 --- ios/web/public/security_style.h | 5 ----- third_party/WebKit/LayoutTests/http/tests/inspector/security/security-state-comparator-expected.txt | 11 ----------- third_party/WebKit/LayoutTests/http/tests/inspector/security/security-state-comparator.html | 1 - third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp | 3 --- third_party/WebKit/Source/core/inspector/browser_protocol.json | 2 +- third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js | 1 - third_party/WebKit/Source/platform/network/ResourceResponse.h | 1 - third_party/WebKit/public/platform/WebURLResponse.h | 1 - 29 files changed, 12 insertions(+), 95 deletions(-) This branch is associated with issue 2329153002. Adding patch to that issue. Upload server: https://codereview.chromium.org (change with -s/--server) Title describing this patch set [Remove the WARNING security level.]: Include Blink enums. Issue updated. URL: https://codereview.chromium.org/2329153002 (patchset: 40001) Uploading base file for third_party/WebKit/Source/platform/network/ResourceResponse.h Uploading base file for third_party/WebKit/public/platform/WebURLResponse.h Uploading base file for third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [Filing this so I don't lose track of the issue.]
,
Sep 14 2016
There are several steps of git cl upload. Is it continuously taking 6 minutes for each change? Doing git cl upload -vv will help by printing out more info for us.
,
Sep 14 2016
,
Sep 14 2016
Thanks for report. What Andy wrote is generally helpful, but it doesn't print timestamps, so i am not sure it would help us figure out which part took longest. Owners check already stands out - git cl already says it took 30s. I don't know why.
,
Sep 28 2016
And also there is a line "Presubmit checks took 304.3s to calculate.". I don't think issue is with git cl here, but rather with inefficient PRESUBMIT.
,
Sep 28 2016
lgarron@ If you can reproduce this, here is what would help: 1. time uploading the same patch bypassing PRESUBMIT checks: git cl upload --bypass-hooks -v -v 2. Edit PRESUBMIT.py and remove a few checks. Then try git cl pres -f and see how long that takes. This way you'd find out which check is slowest. I'm assigning back to you, since I think this isn't really a git cl issue.
,
Sep 28 2016
,
Jan 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ellyjo...@chromium.org
, Sep 14 2016Status: Assigned (was: Untriaged)