New issue
Advanced search Search tips

Issue 645704 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Sep 2016
Cc:
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AsyncResourceHandler reports upload progress every 10ms

Project Member Reported by csharrison@chromium.org, Sep 10 2016 
Was just looking through the upload code and I realized I made a mistake porting the code in https://codereview.chromium.org/1301103002.

I guess we've just had really fast upload progress speeds since then :/

I think the spec says something like 50ms, but we used to use 100ms. Should this move back to 100ms?

Comment 1 by csharrison@chromium.org, Sep 10 2016 

Note: actually we don't send IPCs faster, we just check the requests progress faster.

Comment 2 by mmenke@chromium.org, Sep 10 2016 

Yea, let's just put it back at 100 ms.  We don't want to spoil web developers.

Comment 3 by csharrison@chromium.org, Sep 10 2016

Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90e3f912e7095ec556474e31771e6bafbe0c52f0

commit 90e3f912e7095ec556474e31771e6bafbe0c52f0
Author: csharrison <csharrison@chromium.org>
Date: Fri Sep 30 19:15:44 2016

Report upload progress every 100ms (was 10ms)

This was erroneously changed in a previous patch:
https://codereview.chromium.org/1301103002

Let's revert it back to its original value.

BUG= 645704 

Review-Url: https://codereview.chromium.org/2388453002
Cr-Commit-Position: refs/heads/master@{#422174}

[modify] https://crrev.com/90e3f912e7095ec556474e31771e6bafbe0c52f0/content/browser/loader/async_resource_handler.cc

Comment 5 by csharrison@chromium.org, Sep 30 2016

Status: Fixed (was: Started)
►

Sign in to add a comment