New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645699 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Website Formatting Looks Different

Reported by dang1...@gmail.com, Sep 10 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.101 Safari/537.36

Example URL:
http://www.dailyautograph.com/

Steps to reproduce the problem:
1. Visit the URL
2. It loads correctly and then suddenly changes
3. 

What is the expected behavior?
The menu bar under the header is supposed to be horizontal. The lefthand sidebar is supposed to be next to the top blog post.
The share links under each post should show the icons for each site to be shared to.

What went wrong?
It started on September 3rd when I upgraded Chrome to version 53.0.2785.89 m. It has continued with version 53.0.2785.101 m.

Here's a side by side comparison between how it's supposed to look with Edge and how it looks with Chrome.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? Yes Until I updated to 53.0.2785.89 m.

Does this work in other browsers? Yes 

Chrome version: 53.0.2785.101  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0
 
site.jpg
440 KB View Download
Cc: kavvaru@chromium.org
Components: UI
Labels: -Type-Compat M-53 hasbisect OS-Linux OS-Mac Type-Bug-Regression
Owner: r...@opera.com
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 53.0.2785.101  and canary 55.0.2858.0.

This is regression issue broken in M53.Please find the bisect information as below

Narrow Bisect::
Good::53.0.2780.0  --  (Build revision 402053)
Bad:: 53.0.2781.0  --  (Build revision 402177)

CHANGELOG URL:  https://chromium.googlesource.com/chromium/src/+log/8f96c32e6b2e1e7c96de4187435849c847a2b442..a2a622266768f92196dadb6f55f3425d6bfbf091

from the above CL suspecting the below change
https://chromium.googlesource.com/chromium/src/+/97c1dc4aa9e0e242e1b79ffad84806865c782509

rune@ Could you please look into this issue if it is related to your change,else please re assign to an appropriate dev person.

Thanks,

Comment 2 by r...@opera.com, Sep 13 2016

Setting title dynamically doesn't work.
pref.html
330 bytes View Download

Comment 3 by r...@opera.com, Sep 14 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2337193004
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda0b8d43b6ee62b68639bb10b9a0f76333a3304

commit eda0b8d43b6ee62b68639bb10b9a0f76333a3304
Author: rune <rune@opera.com>
Date: Fri Sep 16 05:51:02 2016

Setting the link title may change the preferred set.

Make sure we set the preferred style sheet set when setting the title
attribute as long as the preferred set name is not already set.

This used to somehow work if the title was set during loading of a
stylesheet since the preferred set name was set during active
stylesheet collection. In other cases, it didn't work until another
stylesheet operation caused a re-collection of active stylesheets.

When setting the preferred name was moved into the LinkStyle::process()
code, it didn't work at all to set the title after the stylesheet
starts loading.

Make sure we set the preferred set name and trigger an active
stylesheet update when the title is changed.

BUG= 645699 

Review-Url: https://codereview.chromium.org/2337193004
Cr-Commit-Position: refs/heads/master@{#419107}

[add] https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304/third_party/WebKit/LayoutTests/fast/css/change-title-enabling-alternate.html
[modify] https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304/third_party/WebKit/Source/core/dom/StyleEngine.h
[modify] https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/eda0b8d43b6ee62b68639bb10b9a0f76333a3304/third_party/WebKit/Source/core/html/HTMLLinkElement.h

Comment 5 by r...@opera.com, Sep 16 2016

Status: Fixed (was: Started)

Comment 6 by dang1...@gmail.com, Sep 19 2016

Hi, I appreciate you all looking into this, but it's been 2 weeks and 3
stable updates have been released. My site still looks the same. Will my
site ever revert to its original state, or do I need to use a new template?

Comment 7 by r...@opera.com, Sep 21 2016

Components: -UI Blink>CSS
Labels: -OS-Windows -OS-Mac Merge-Request-54 OS-All
Requesting merge to M-54.

Comment 8 by r...@opera.com, Sep 21 2016

Cc: nyerramilli@chromium.org ranjitkan@chromium.org r...@opera.com
 Issue 645930  has been merged into this issue.

Comment 9 by dimu@chromium.org, Sep 21 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 21 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40

commit 7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40
Author: Rune Lillesveen <rune@opera.com>
Date: Wed Sep 21 12:32:26 2016

Setting the link title may change the preferred set.

Make sure we set the preferred style sheet set when setting the title
attribute as long as the preferred set name is not already set.

This used to somehow work if the title was set during loading of a
stylesheet since the preferred set name was set during active
stylesheet collection. In other cases, it didn't work until another
stylesheet operation caused a re-collection of active stylesheets.

When setting the preferred name was moved into the LinkStyle::process()
code, it didn't work at all to set the title after the stylesheet
starts loading.

Make sure we set the preferred set name and trigger an active
stylesheet update when the title is changed.

BUG= 645699 

Review-Url: https://codereview.chromium.org/2337193004
Cr-Commit-Position: refs/heads/master@{#419107}
(cherry picked from commit eda0b8d43b6ee62b68639bb10b9a0f76333a3304)

Conflicts:
	third_party/WebKit/Source/core/html/HTMLLinkElement.h

Review URL: https://codereview.chromium.org/2357163002 .

Cr-Commit-Position: refs/branch-heads/2840@{#462}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/LayoutTests/fast/css/change-title-enabling-alternate.html
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/dom/StyleEngine.h
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/html/HTMLLinkElement.h

Comment 11 by ajha@chromium.org, Sep 28 2016

Labels: TE-Verified-54.0.2840.41 TE-Verified-M54
Verified the merge on the latest M-54(54.0.2840.41) on Windows-10, Mac OS 10.11.6 and Linux Ubuntu 14.04. This is working as intended hence adding the verified label.


645699.png
2.2 MB View Download

Comment 12 by dang1...@gmail.com, Oct 20 2016

Just an update for you all. I switched to the beta version and my site
displays just as intended. Today, I checked my site on Android mobile using
Chrome and it's the same unresolved issue. What can I do?

Comment 13 by r...@opera.com, Oct 21 2016

Which version of Android Chrome?

You should be able to make the site work in the presence of this bug by not using preferred style sheet sets.

Comment 14 by dang1...@gmail.com, Oct 21 2016

I'm only using Blogger templates. I don't know CSS. That's why I don’t
understand why I'm having these issues.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40

commit 7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40
Author: Rune Lillesveen <rune@opera.com>
Date: Wed Sep 21 12:32:26 2016

Setting the link title may change the preferred set.

Make sure we set the preferred style sheet set when setting the title
attribute as long as the preferred set name is not already set.

This used to somehow work if the title was set during loading of a
stylesheet since the preferred set name was set during active
stylesheet collection. In other cases, it didn't work until another
stylesheet operation caused a re-collection of active stylesheets.

When setting the preferred name was moved into the LinkStyle::process()
code, it didn't work at all to set the title after the stylesheet
starts loading.

Make sure we set the preferred set name and trigger an active
stylesheet update when the title is changed.

BUG= 645699 

Review-Url: https://codereview.chromium.org/2337193004
Cr-Commit-Position: refs/heads/master@{#419107}
(cherry picked from commit eda0b8d43b6ee62b68639bb10b9a0f76333a3304)

Conflicts:
	third_party/WebKit/Source/core/html/HTMLLinkElement.h

Review URL: https://codereview.chromium.org/2357163002 .

Cr-Commit-Position: refs/branch-heads/2840@{#462}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/LayoutTests/fast/css/change-title-enabling-alternate.html
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/dom/StyleEngine.h
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/7afc70c366cbd7fcb0ae9f0e767e6a35ccb5ea40/third_party/WebKit/Source/core/html/HTMLLinkElement.h

Sign in to add a comment