Authentication doesn't work for immediate log viewing. |
||
Issue descriptionBecause LogDog log viewer authentication happens asynchronously, the logs begin to load before the authentication is complete. Update the web viewer to re-submit requests when/if authentication is complete.
,
Sep 13 2016
https://codereview.chromium.org/2335223003/ has been deployed to live servers, seems to be working.
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/500fb4485ac91f2ba636ed03e492123aa64b8a3f commit 500fb4485ac91f2ba636ed03e492123aa64b8a3f Author: Dan Jacques <dnj@chromium.org> Date: Fri Sep 16 23:44:24 2016 LogDog: Update web code, stream/query with auth. Add facilities to display web viewer status, retry on missing stream, and retry with authentication when available. Authentication occurs as an optional asynchronous event. This wires that event up to a retry hook that will retry the stream query and/or stream fetching when previous attempts failed for authentication reasons. If authentication isn't necessary, it will not be used and the first attempt will succeed. Additionally, update the web query code to move more logic out of the core Polymer area and into standalone objects. The plan is to move those objects over to TypeScript and add unit tests for their behaviors. This should be much easier now that the objects are testable without a full Polymer setup. BUG= chromium:645692 TEST=local - Streamed logs from protected and non-protected projects. - Successfully logged in after failure and loaded logs. - Successfully queried for logs where the query required authentication. - Successfully loaded multiple log streams. Review URL: https://codereview.chromium.org/2335223003 . [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/apps/logdog-app/elements/elements.html [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/apps/logdog-view/elements/elements.html [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/apps/logdog-view/elements/logdog-view/logdog-view.html [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/bower.json [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/inc/auth/auth-signin.html [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/inc/logdog-stream-view/logdog-stream-fetcher.html [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/inc/logdog-stream-view/logdog-stream-query.html [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/inc/logdog-stream-view/logdog-stream-view.html [add] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/inc/logdog-stream/logdog-error.html [modify] https://crrev.com/500fb4485ac91f2ba636ed03e492123aa64b8a3f/web/inc/logdog-stream/logdog-stream.html |
||
►
Sign in to add a comment |
||
Comment 1 by akes...@chromium.org
, Sep 11 2016