New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645660 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Sep 2016
Cc:
reillyg@chromium.org
█ yzshen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Mojo bindings variants are not inherited in target deps

Project Member Reported by roc...@chromium.org, Sep 9 2016 
If I have mojom("foo") and it depends on a mojom("bar") target, "foo_blink" should implicitly depend on "bar_blink" and not on the non-variant "bar". This is not currently working.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a803c034985e873747aebb91769258a7842cac69

commit a803c034985e873747aebb91769258a7842cac69
Author: rockot <rockot@chromium.org>
Date: Sat Sep 10 00:44:19 2016

mojom GNI: Implicit variant inheritance for deps

If a mojom target foo depends on mojom target bar, we want
the "foo_blink" target to depend on "bar_blink" implicitly.

This makes that happen.

BUG= 645660 
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2328873004
Cr-Commit-Position: refs/heads/master@{#417782}

[modify] https://crrev.com/a803c034985e873747aebb91769258a7842cac69/mojo/public/tools/bindings/mojom.gni

Comment 2 by roc...@chromium.org, Sep 10 2016

Status: Fixed (was: Started)
►

Sign in to add a comment