Layout test failures with buffer size. |
||
Issue descriptionBuild is broken: message_center_unittests on Ubuntu-12.04 Revision range: chromium 417624 : 417647 Failing builders: Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(dbg)(1) and many others Output: [14187:14187:0909/124509:9849663588:FATAL:list_container_helper.cc(460)] Check failed: size_of_actual_element_in_bytes <= data_->element_size() (248 vs. 224) #0 0x7faf8b4e7b3e base::debug::StackTrace::StackTrace() #1 0x7faf8b5498ac logging::LogMessage::~LogMessage() #2 0x7faf863e61d5 cc::ListContainerHelper::Allocate() #3 0x7faf86104a0c cc::ListContainer<>::AllocateAndConstruct<>() #4 0x7faf8610424c cc::RenderPass::CreateAndAppendDrawQuad<>() #5 0x7faf86103b1e cc::RenderSurfaceImpl::AppendQuads() #6 0x7faf8631b7c7 cc::AppendQuadsForRenderSurfaceLayer() #7 0x7faf8631a4de cc::LayerTreeHostImpl::CalculateRenderPasses() #8 0x7faf8631cb53 cc::LayerTreeHostImpl::PrepareToDraw() #9 0x7faf863c9005 cc::SingleThreadProxy::DoComposite() #10 0x7faf863c9ea9 cc::SingleThreadProxy::ScheduledActionDrawAndSwapIfPossible() #11 0x7faf8625f107 cc::Scheduler::DrawAndSwapIfPossible() #12 0x7faf8625a9e2 cc::Scheduler::ProcessScheduledActions() #13 0x7faf8625a5f2 cc::Scheduler::OnBeginImplFrameDeadline() #14 0x7faf860ab102 _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_ #15 0x7faf862625da _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc9SchedulerEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #16 0x7faf86262562 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #17 0x7faf862623ac _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #18 0x7faf860ab2cd base::Callback<>::Run() #19 0x7faf860aadf9 base::CancelableCallback<>::Forward() #20 0x7faf860ab102 _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_ #21 0x7faf860ab05a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMNS_18CancelableCallbackIFvvEEEKFvvERKNS_7WeakPtrIS6_EEJEEEvOT_OT0_DpOT1_ #22 0x7faf860aafe2 _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvvEEEKFvvEJNS_7WeakPtrIS5_EEEEES4_E7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #23 0x7faf860aae2c _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvvEEEKFvvEJNS_7WeakPtrIS5_EEEEES4_E3RunEPNS0_13BindStateBaseE #24 0x7faf8b4bad6d base::Callback<>::Run() #25 0x7faf8b4ecb7b base::debug::TaskAnnotator::RunTask() #26 0x7faf8b566901 base::MessageLoop::RunTask() #27 0x7faf8b566b84 base::MessageLoop::DeferOrRunPendingTask() #28 0x7faf8b566e4e base::MessageLoop::DoWork() #29 0x7faf8b57c0d6 base::MessagePumpGlib::Run() #30 0x7faf8b56636a base::MessageLoop::RunHandler() #31 0x7faf8b6002b4 base::RunLoop::Run() #32 0x7faf8b6004e9 base::RunLoop::RunUntilIdle() #33 0x000000a6bfc1 ash::test::AshTestHelper::RunAllPendingInMessageLoop() #34 0x000000a6a9d1 ash::test::AshTestBase::RunAllPendingInMessageLoop() #35 0x000000559b71 ash::test::SystemTrayTest_SystemTrayNotifications_Test::TestBody() #36 0x000000a2858a testing::internal::HandleSehExceptionsInMethodIfSupported<>() #37 0x000000a1932e testing::internal::HandleExceptionsInMethodIfSupported<>() #38 0x000000a0e0e5 testing::Test::Run() #39 0x000000a0e808 testing::TestInfo::Run() #40 0x000000a0edaa testing::TestCase::Run() #41 0x000000a140fc testing::internal::UnitTestImpl::RunAllTests() #42 0x000000a2c65a testing::internal::HandleSehExceptionsInMethodIfSupported<>() #43 0x000000a1aa9e testing::internal::HandleExceptionsInMethodIfSupported<>() #44 0x000000a13d9f testing::UnitTest::Run() #45 0x0000009b8451 RUN_ALL_TESTS() #46 0x0000009b73b2 base::TestSuite::Run() #47 0x000000545b8d _ZN4base8internal13FunctorTraitsIMN3ash18ScreenTrayItemTestEFvvEvE6InvokeIPNS2_45ScreenShareTest_NotificationStartAndStop_TestEJEEEvS5_OT_DpOT0_ #48 0x000000545ab1 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3ash18ScreenTrayItemTestEFvvEJPNS4_45ScreenShareTest_NotificationStartAndStop_TestEEEEvOT_DpOT0_ #49 0x0000006fdd07 _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIN3ash4test18AuraShellTestSuiteEEEEEEFivEE7RunImplIRKS5_RKSt5tupleIJSA_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #50 0x0000006fdb4c _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIN3ash4test18AuraShellTestSuiteEEEEEEFivEE3RunEPNS0_13BindStateBaseE #51 0x00000052b1ad base::Callback<>::Run() #52 0x0000009bb28e base::(anonymous namespace)::LaunchUnitTestsInternal() #53 0x0000009bb124 base::LaunchUnitTests() #54 0x0000006fda23 main #55 0x7faf802cd7ed __libc_start_main #56 0x0000004ab305 <unknown> Suspected CL: https://codereview.chromium.org/2328433005
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/208f4013ba1cab8f188beb508915c49abe5ebdf7 commit 208f4013ba1cab8f188beb508915c49abe5ebdf7 Author: dmurph <dmurph@chromium.org> Date: Fri Sep 09 21:02:01 2016 Revert of Fix kLargestDrawQuadSize (patchset #1 id:1 of https://codereview.chromium.org/2328433005/ ) Reason for revert: Reverting, I think this caused buffer size issues https://bugs.chromium.org/p/chromium/issues/detail?id=645634 BUG= 645634 Original issue's description: > Fix kLargestDrawQuadSize > > This should work, but triggered a bug in the past. > Trying again, if nothing else I'll find out what problem was triggered. > > BUG= 644443 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/e099ceca4f5145bf650a2293807c585cc717121f > Cr-Commit-Position: refs/heads/master@{#417646} TBR=danakj@chromium.org,hubbe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 644443 Review-Url: https://codereview.chromium.org/2326153002 Cr-Commit-Position: refs/heads/master@{#417708} [modify] https://crrev.com/208f4013ba1cab8f188beb508915c49abe5ebdf7/cc/quads/draw_quad_unittest.cc [modify] https://crrev.com/208f4013ba1cab8f188beb508915c49abe5ebdf7/cc/quads/largest_draw_quad.cc
,
Sep 9 2016
Boy that's really confusing. We're adding a quad larger than the largest quad? Can you please figure this out :/
,
Sep 12 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dmu...@chromium.org
, Sep 9 2016