New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 703798



Sign in to add a comment

Implement parsing of Colour element in WebM parser

Project Member Reported by servolk@chromium.org, Sep 9 2016

Issue description

For WebM/VP9 streams, the HDR metadata is signaled and delivered in the newly proposed 'Colour element' of the WebM container.

http://www.webmproject.org/docs/container/#colour

 
Cc: hubbe@chromium.org ddorwin@chromium.org
I'm wondering if we should switch to libwebm parser in Chromium instead of adding Colour element support to the existing webm parser under media/formats/webm. Sent out an e-mail to start a discussion.
After some further discussion with fgalligan@ we've decided that for now it's easier to add the support for reading Colour element in the current WebM parser, rather that switch to libwebm.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3

commit e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3
Author: servolk <servolk@chromium.org>
Date: Fri Sep 23 00:52:58 2016

Add color metadata info to VideoDecoderConfig.

Also implemented reading color metadata from the Colour element in WebM containers.

BUG= 645626 

Review-Url: https://codereview.chromium.org/2333663003
Cr-Commit-Position: refs/heads/master@{#420511}

[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/BUILD.gn
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/base/BUILD.gn
[add] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/base/hdr_metadata.cc
[add] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/base/hdr_metadata.h
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/base/video_decoder_config.cc
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/base/video_decoder_config.h
[add] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/formats/webm/webm_colour_parser.cc
[add] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/formats/webm/webm_colour_parser.h
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/formats/webm/webm_constants.h
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/formats/webm/webm_parser.cc
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/formats/webm/webm_stream_parser_unittest.cc
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/formats/webm/webm_video_client.cc
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/formats/webm/webm_video_client.h
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/test/data/README
[add] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/media/test/data/colour.webm
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/ui/gfx/color_space.h
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/ui/gfx/color_transform.cc
[modify] https://crrev.com/e21ae6e132cd646d0fc8f3aeda071e0d2e5bc4f3/ui/gfx/color_transform_unittest.cc

Status: Fixed (was: Assigned)
Blocking: 703798

Sign in to add a comment