New issue
Advanced search Search tips

Issue 645623 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: ----



Sign in to add a comment

Build failure

Project Member Reported by dmu...@chromium.org, Sep 9 2016

Issue description

Build is broken:
compile

Revision range:
chromium 417667 : 417680

Failing builders:
Android: https://build.chromium.org/p/chromium/builders/Android

In file included from ../../testing/gtest/include/gtest/gtest.h:1878:0,
                 from ../../components/cronet/url_request_context_config_unittest.cc:15:
../../components/cronet/url_request_context_config_unittest.cc: In member function 'virtual void cronet::URLRequestContextConfigTest_TestExperimentalOptionPassing_Test::TestBody()':
../../components/cronet/url_request_context_config_unittest.cc:101:25: error: 'const struct net::HttpNetworkSession::Params' has no member named 'quic_max_number_of_lossy_connections'
   EXPECT_EQ(10, params->quic_max_number_of_lossy_connections);
                         ^
../../testing/gtest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'
   if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                    ^
../../testing/gtest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'
   GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
   ^
../../testing/gtest/include/gtest/gtest.h:1927:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'
   EXPECT_PRED_FORMAT2(::testing::internal:: \
   ^
../../components/cronet/url_request_context_config_unittest.cc:101:3: note: in expansion of macro 'EXPECT_EQ'
   EXPECT_EQ(10, params->quic_max_number_of_lossy_connections);
   ^
../../components/cronet/url_request_context_config_unittest.cc:102:33: error: 'const struct net::HttpNetworkSession::Params' has no member named 'quic_packet_loss_threshold'
   EXPECT_FLOAT_EQ(0.5f, params->quic_packet_loss_threshold);
                                 ^
../../testing/gtest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'
   if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                    ^
../../testing/gtest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'
   GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
   ^
../../testing/gtest/include/gtest/gtest.h:2032:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'
   EXPECT_PRED_FORMAT2(::testing::internal::CmpHelperFloatingPointEQ<float>, \
   ^
../../components/cronet/url_request_context_config_unittest.cc:102:3: note: in expansion of macro 'EXPECT_FLOAT_EQ'
   EXPECT_FLOAT_EQ(0.5f, params->quic_packet_loss_threshold);
   ^

Suspected CL:
https://codereview.chromium.org/2318053004
 
Cc: dmu...@chromium.org
Labels: -Pri-2 Pri-0
Owner: rch@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca

commit 44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca
Author: dmurph <dmurph@chromium.org>
Date: Fri Sep 09 20:39:09 2016

Revert of Remove obsolete QUIC disabling code. (patchset #4 id:60001 of https://codereview.chromium.org/2318053004/ )

Reason for revert:
test build broken on Android
BUG= 645623 

Original issue's description:
> Remove obsolete QUIC disabling code.
>
> No longer disable QUIC based on public resets post handshake or packet loss during the handshake. Also remove the "k of n" tracking and per-port disablement.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/1c1aa05eaa6b2a04c51e175ed76b5c6f810ff0aa
> Cr-Commit-Position: refs/heads/master@{#417677}

TBR=eroman@chromium.org,ckrasic@chromium.org,ianswett@chromium.org,rch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2327923002
Cr-Commit-Position: refs/heads/master@{#417694}

[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/chrome/browser/resources/net_internals/quic_view.html
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/components/network_session_configurator/network_session_configurator.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/components/network_session_configurator/network_session_configurator_unittest.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/http/http_network_session.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/http/http_network_session.h
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/log/bounded_file_net_log_observer_unittest.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/quic/chromium/quic_chromium_client_session.h
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/quic/chromium/quic_stream_factory_test.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/quic/test_tools/quic_stream_factory_peer.cc
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/quic/test_tools/quic_stream_factory_peer.h
[modify] https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca/net/url_request/url_request_context_builder.cc

Project Member

Comment 3 by sheriffbot@chromium.org, Sep 24 2016

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by rch@chromium.org, Sep 25 2016

Status: Fixed (was: Available)

Sign in to add a comment