New issue
Advanced search Search tips

Issue 645622 link

Starred by 1 user
Status: Fixed
Merged: issue 644042
Owner:
martiniss@chromium.org
Closed: Sep 2016
Cc:
seanmccullough@chromium.org
martiniss@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Blame list seems wrong

Project Member Reported by dmu...@chromium.org, Sep 9 2016 
Problem with Sheriff-o-Matic


When I go to the "compile failure on chromium/Android" issue, it says just one CL did it. But this can't be right. The build has maaaany more.

https://sheriff-o-matic-staging.appspot.com/chromium/examine/chromium.Android.compile.

Comment 2 by zhangtiff@chromium.org, Sep 9 2016

Labels: Milestone-SoMNG

Comment 3 by zhangtiff@chromium.org, Sep 12 2016 

I'm trying to investigate this a bit more. Unfortunately, neither version of Sheriff-o-Matic keeps alerts alive for very long, so the Examine link is not useful anymore. 

But, if I'm understanding correctly, it seems the problem is that the revision ranges show in the new Sheriff-o-Matic are not as accurate as the old ones?

Comment 4 by zhangtiff@chromium.org, Sep 13 2016 

I think I found an example of this problem and will post screenshots here for reference since examine links tend to expire. These seem to be the same failure. 

New sheriff-o-Matic (418275-418284): https://screenshot.googleplex.com/wv5S92Uv5jA
Old Sheriff-o-Matic (418284-418284): https://screenshot.googleplex.com/wWbPewwvYHr

Comment 5 Deleted

Comment 6 by zhangtiff@chromium.org, Sep 13 2016

Status: Untriaged (was: Duplicate)

Comment 7 by seanmccullough@google.com, Sep 15 2016

Status: Available (was: Untriaged)

Comment 8 by martiniss@chromium.org, Sep 15 2016

Owner: martiniss@chromium.org
Status: Started (was: Available)
I'll take a stab at this.

Comment 9 by martiniss@chromium.org, Sep 16 2016 

I believe I've fixed this

Old site: https://screenshot.googleplex.com/JfsoTGhhnjz
New fix: https://screenshot.googleplex.com/go4ZQiuJOKB

CL on the way.

Comment 10 by seanmccullough@google.com, Sep 26 2016 

Did you have a CL for this?

Comment 11 by martiniss@chromium.org, Sep 26 2016

Status: Fixed (was: Started)
oh yeah. https://chromium-review.googlesource.com/c/386329/ was the fix.
►

Sign in to add a comment