The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95aa6bbeda2fb1472a1d78c60bdece391bbf7cef

commit 95aa6bbeda2fb1472a1d78c60bdece391bbf7cef
Author: dmurph <dmurph@chromium.org>
Date: Fri Sep 09 20:32:26 2016

Revert of Roll recipe dependencies (trivial). (patchset #1 id:1 of https://codereview.chromium.org/2325983003/ )

Reason for revert:
reverting due to build gen issues:
https://bugs.chromium.org/p/chromium/issues/detail?id=645621
BUG= 645621 

Original issue's description:
> Roll recipe dependencies (trivial).
>
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
>
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
> (or complain)
>
> build:
>   https://crrev.com/662146213f2951d6caa4185fbe832d82e5cf95b1 Remove support for url_suffix from pgo api (agable@chromium.org)
>
> TBR=martiniss@chromium.org,phajdan.jr@chromium.org
> BUG=645344
>
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Committed: https://crrev.com/40456d0b7fa3f4bfc1ea6030469479fcacaa37b9
> Cr-Commit-Position: refs/heads/master@{#417676}

TBR=martiniss@chromium.org,phajdan.jr@chromium.org,recipe-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645344

Review-Url: https://codereview.chromium.org/2329583002
Cr-Commit-Position: refs/heads/master@{#417692}

[modify] https://crrev.com/95aa6bbeda2fb1472a1d78c60bdece391bbf7cef/infra/config/recipes.cfg

I doubt the roll had anything to do with this; it was a pgo specific.

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10699 is the first failure. Nothing on the blamelist really looks suspicious :( 

I don't know this system, can you guys help at all?

Confirming the revert did nothing. https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10705 had the revert, and it and the next couple builds didn't pass. The recipe-roller relanded the change (which it probably shouldn't do) in https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10708, and the build still failed.

re #4 this appears to be a GN issue. I've cc-ed the current trooper (agable@) already, who should be able to help a bit. Also blindly cc-ing dpranke@, who knows about GN :)

It's pretty clearly this CL: https://codereview.chromium.org/2328773002

The error log says:
The item //third_party/WebKit/Source/modules:modules_0
can not depend on //third_party/WebKit/Source/bindings/modules:generated
because it is not in //third_party/WebKit/Source/bindings/modules:generated's visibility list: [
  //third_party/WebKit/Source/modules:modules
]

The CL changes the visibility of things in third_party/WebKit/Source/modules/BUILD.gn

That CL is in the blamelist on the first failing build: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10699

Assigning to brettw to revert or fix that CL.

I don't understand how I missed that.

reverted

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/668425a36f0df11b34d55753fe7d4750d47f7ab9

commit 668425a36f0df11b34d55753fe7d4750d47f7ab9
Author: brettw <brettw@chromium.org>
Date: Sat Sep 10 04:16:06 2016

Fix official Windows build.

Fix visibility when using split static libraries.

NOTRY=true
BUG= 645621 
TBR=dmurph

Review-Url: https://codereview.chromium.org/2327353002
Cr-Commit-Position: refs/heads/master@{#417819}

[modify] https://crrev.com/668425a36f0df11b34d55753fe7d4750d47f7ab9/third_party/WebKit/Source/bindings/modules/BUILD.gn