1. CQ: use $HOST/project/path instead of project/path 2. rename weird event.ref etc.
I mark it as a bug because this legacy really should be cleaned up.
Doc: https://docs.google.com/document/d/1rbz2TjCVyIctz-Wn_snJ4HWKCHHUt4GDfMMU_LXqGPQ/edit?ts=57fd368d#heading=h.68yn0dvicej4
CLs: recipe engine: https://codereview.chromium.org/2442173003 bot_update https://codereview.chromium.org/2439373002 infra: https://chromium-review.googlesource.com/401339 Build: https://codereview.chromium.org/2442203002/ Internal repos: https://chromereviews.googleplex.com/534607013
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/51a7b096ca3e9a16e175794de001f9f04e066839 commit 51a7b096ca3e9a16e175794de001f9f04e066839 Author: tandrii <tandrii@chromium.org> Date: Tue Oct 25 13:38:28 2016 bot_update: understand new Gerrit patch properties. This change is backwards compatible, so no expectation changes expected in downstream rolls. Depends on https://codereview.chromium.org/2442173003 recipe_engine change. BUG= 645616 R=martiniss@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2439373002 [modify] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/bot_update/__init__.py [modify] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/bot_update/api.py [modify] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json [add] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/bot_update/example.expected/tryjob_gerrit_angle_deprecated.json [modify] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/bot_update/example.py [modify] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/tryserver/api.py [add] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/tryserver/example.expected/with_gerrit_patch.json [add] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/tryserver/example.expected/with_gerrit_patch_deprecated.json [modify] https://crrev.com/51a7b096ca3e9a16e175794de001f9f04e066839/recipe_modules/tryserver/example.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/b00c0cb083e0255aea24133f78b66ef9de8efb78 commit b00c0cb083e0255aea24133f78b66ef9de8efb78 Author: tandrii <tandrii@google.com> Date: Wed Oct 26 12:41:27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/e3c40663ad7cee755da129417d624c0a72962723 commit e3c40663ad7cee755da129417d624c0a72962723 Author: tandrii <tandrii@chromium.org> Date: Wed Oct 26 12:47:25 2016 Update recipes to understand new Gerrit patch properties. Backwards compatible. Depends on https://codereview.chromium.org/2439373002 change to bot_update. BUG= 645616 R=machenbach@chromium.org,martiniss@chromium.org Review-Url: https://codereview.chromium.org/2442203002 [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/boringssl.expected/gerrit_cl.json [add] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/boringssl.expected/gerrit_cl_deprecated.json [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/boringssl.py [add] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/boringssl_docs.expected/boringssl-docs-gerrit-deprecated.json [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/boringssl_docs.expected/boringssl-docs-gerrit.json [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/boringssl_docs.py [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit.json [add] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit_deprecated.json [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/run_presubmit.py [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/simple_ci.expected/cq_try.json [modify] https://crrev.com/e3c40663ad7cee755da129417d624c0a72962723/scripts/slave/recipes/simple_ci.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/9aa27bc3981a5141f7f3befcb105b0ff2de982b1 commit 9aa27bc3981a5141f7f3befcb105b0ff2de982b1 Author: tandrii <tandrii@google.com> Date: Thu Oct 27 10:21:21 2016
The above commit is the one deploying new properties to CQ.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/4d55350067c6936fefb8d5949edcd8a0a4697a1d commit 4d55350067c6936fefb8d5949edcd8a0a4697a1d Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Oct 24 11:28:05 2016 Make use of updated Gerrit trybot properties. Depends on https://codereview.chromium.org/2442173003 and implementation in CQ and bot_update. R=machenbach@chromium.org,sergiyb@chromium.org BUG= 645616 Change-Id: If41b78f2756a54ed784a2efa3258ab5e2665f29d Reviewed-on: https://chromium-review.googlesource.com/401339 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/4d55350067c6936fefb8d5949edcd8a0a4697a1d/recipes/recipes/gerrit_cq_test.expected/try.json [modify] https://crrev.com/4d55350067c6936fefb8d5949edcd8a0a4697a1d/recipes/recipes/gerrit_cq_test.py [modify] https://crrev.com/4d55350067c6936fefb8d5949edcd8a0a4697a1d/recipes/recipes/infra_repo_trybot.expected/basic_gerrit.json [modify] https://crrev.com/4d55350067c6936fefb8d5949edcd8a0a4697a1d/recipes/recipes/infra_repo_trybot.expected/infra_internal_gerrit.json [modify] https://crrev.com/4d55350067c6936fefb8d5949edcd8a0a4697a1d/recipes/recipes/infra_repo_trybot.py
+Ravi sorry for not including your earlier.
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e68db49c1f93516e2a380eab5575bc2bb08c9878 commit e68db49c1f93516e2a380eab5575bc2bb08c9878 Author: tandrii <tandrii@google.com> Date: Mon Oct 31 20:38:26 2016
State so far: new properties deployed. Old properties are being cleaned up.
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/4a489a1fd299bdf4e37b300bd6b9bc3de009165e commit 4a489a1fd299bdf4e37b300bd6b9bc3de009165e Author: tandrii <tandrii@google.com> Date: Wed Nov 02 22:58:18 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/c13e4d1009cfa44257fd1eeb2c1f4a9109644cc9 commit c13e4d1009cfa44257fd1eeb2c1f4a9109644cc9 Author: tandrii <tandrii@google.com> Date: Wed Nov 02 23:25:49 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/9701c7c16dc3afd5bade605d4c4ac911c2478aa1 commit 9701c7c16dc3afd5bade605d4c4ac911c2478aa1 Author: tandrii <tandrii@chromium.org> Date: Wed Nov 02 23:44:33 2016 Recipes: Stop using tryserver_gerrit in depot_tools. Only changes how test properties are given, no change in functionality. Should enable recipe roll of https://codereview.chromium.org/2464673002. R=martiniss@chromium.org,machenbach@chromium.org BUG= chromium:645616 Review-Url: https://codereview.chromium.org/2468373002 [modify] https://crrev.com/9701c7c16dc3afd5bade605d4c4ac911c2478aa1/recipe_modules/bot_update/example.py [modify] https://crrev.com/9701c7c16dc3afd5bade605d4c4ac911c2478aa1/recipe_modules/tryserver/example.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/b78581e2d8b96f56424b901c3224b5268813b2f6 commit b78581e2d8b96f56424b901c3224b5268813b2f6 Author: tandrii <tandrii@chromium.org> Date: Mon Nov 07 13:11:40 2016 Stop supporting old Gerrit CQ tryjob properties. R=machenbach@chromium.org BUG= chromium:645616 Review-Url: https://codereview.chromium.org/2463653002 [delete] https://crrev.com/03b8919a338f141965d3320d4f60a22ae03085c9/scripts/slave/recipes/boringssl.expected/gerrit_cl_deprecated.json [modify] https://crrev.com/b78581e2d8b96f56424b901c3224b5268813b2f6/scripts/slave/recipes/boringssl.py [delete] https://crrev.com/03b8919a338f141965d3320d4f60a22ae03085c9/scripts/slave/recipes/boringssl_docs.expected/boringssl-docs-gerrit-deprecated.json [modify] https://crrev.com/b78581e2d8b96f56424b901c3224b5268813b2f6/scripts/slave/recipes/boringssl_docs.py [delete] https://crrev.com/03b8919a338f141965d3320d4f60a22ae03085c9/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit_deprecated.json [modify] https://crrev.com/b78581e2d8b96f56424b901c3224b5268813b2f6/scripts/slave/recipes/run_presubmit.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/032cf1306dc5f966ee617908d2a3d518853a7d21 commit 032cf1306dc5f966ee617908d2a3d518853a7d21 Author: Yoshisato Yanagisawa <yyanagisawa@google.com> Date: Fri Dec 02 01:44:10 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/546bb3a34dfa8c072f4fea60ac00268a3fba5df2 commit 546bb3a34dfa8c072f4fea60ac00268a3fba5df2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Mar 02 14:25:40 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/be1b6aafae6e95e1cc58d5b33ae92bc037efd46b commit be1b6aafae6e95e1cc58d5b33ae92bc037efd46b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Mar 02 16:47:09 2017 Use patch_repository_url in Gerrit. CQ used incorrect property before (fixed in https://chrome-internal-review.googlesource.com/c/332743), and that's why I mistakenly asked to use the wrong property here. R=andybons@chromium.org BUG= 645616 , 685318 Change-Id: Ibe381f9937bc39bb0fba19c08f1a52724ac2ee54 Reviewed-on: https://chromium-review.googlesource.com/448459 Reviewed-by: Andrew Bonventre <andybons@chromium.org> [modify] https://crrev.com/be1b6aafae6e95e1cc58d5b33ae92bc037efd46b/test/cr-tryjob-picker_test.html [modify] https://crrev.com/be1b6aafae6e95e1cc58d5b33ae92bc037efd46b/src/main/resources/static/cr-tryjob-picker.js
Comment 1 by tandrii@chromium.org
, Sep 9 2016