"org.chromium.content.browser.ScreenOrientationListenerTest" is flaky |
||||||||||||
Issue description"org.chromium.content.browser.ScreenOrientationListenerTest#testVariousOrientationChanges" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYwsSBUZsYWtlIlhvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlNjcmVlbk9yaWVudGF0aW9uTGlzdGVuZXJUZXN0I3Rlc3RWYXJpb3VzT3JpZW50YXRpb25DaGFuZ2VzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 9 2016
just disable it this tools is actually more strict about what "flake" means. flake actually means failed in one bot run, but then succeeded on the next. any android instrumentation test that makes that list should me immediately disabled
,
Sep 12 2016
Disabling in https://codereview.chromium.org/2332703002/ boliu@: can you help setting a suitable component so this bug is not lost?
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73b7ebc3c21d4c7ff96d16e1ce728980426436e5 commit 73b7ebc3c21d4c7ff96d16e1ce728980426436e5 Author: kjellander <kjellander@chromium.org> Date: Mon Sep 12 08:27:40 2016 Disable ScreenOrientationListenerTest.testVariousOrientationChanges test due to flakiness. BUG=645609 TBR=boliu@chromium.org Review-Url: https://codereview.chromium.org/2332703002 Cr-Commit-Position: refs/heads/master@{#417894} [modify] https://crrev.com/73b7ebc3c21d4c7ff96d16e1ce728980426436e5/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java
,
Sep 12 2016
Labels look correct to me.. android doesn't have finely curated and monitor labels :/ +mlamouri who wrote the tests
,
Sep 15 2016
testFlipLandscape is similarly afflicated, starting at the same time on N5X: https://bugs.chromium.org/p/chromium/issues/detail?id=647058
,
Sep 15 2016
Issue 647058 has been merged into this issue.
,
Sep 15 2016
Note that this started around the same time on the N5X because that's around when the N5X bot was enabled on the CQ: https://codereview.chromium.org/2318813002
,
Sep 15 2016
Assigning to mlamouri so this has an owner.
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/925b8063d1de2006147e1834894b82767ef227cd commit 925b8063d1de2006147e1834894b82767ef227cd Author: jbroman <jbroman@chromium.org> Date: Thu Sep 15 15:30:28 2016 Disable ScreenOrientationListenerTest#testFlipLandscape, which is flaky. BUG= 647058 ,645609 TBR=mlamouri@chromium.org Review-Url: https://codereview.chromium.org/2341073002 Cr-Commit-Position: refs/heads/master@{#418872} [modify] https://crrev.com/925b8063d1de2006147e1834894b82767ef227cd/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java
,
Dec 8 2016
Both org.chromium.content.browser.ScreenOrientationListenerTest#testOrientationChanges and org.chromium.content.browser.ScreenOrientationListenerTest#testBasicValues are flakily timing out with: org.chromium.content.browser.ScreenOrientationListenerTest#testOrientationChanges (run #1): java.util.concurrent.TimeoutException: waitForCallback timed out! at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183) at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:219) at org.chromium.content.browser.ScreenOrientationListenerTest.lockOrientationAndWait(ScreenOrientationListenerTest.java:160) at org.chromium.content.browser.ScreenOrientationListenerTest.testOrientationChanges(ScreenOrientationListenerTest.java:167) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:256) at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) Example builds: https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82230 https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82226 https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82218 https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82217
,
Dec 8 2016
,
Dec 8 2016
#11: android_n5x_swarming_rel is having issues today.
,
Dec 8 2016
Indeed, but given that these tests were flaky before, this might be a different issue.
,
Dec 8 2016
not nearly at the same rate.
,
Dec 8 2016
Issue 672345 has been merged into this issue.
,
Dec 8 2016
Assigning to lunalu@ who rewrote a large chunk of the backend of the screen orientation code.
,
Dec 20 2016
I didn't really touch screen orientation listener. I was working on screen orientation lock / unlock request. I could take a look at it. But I think it is best for the people that wrote screen orientation listener to take over this bug.
,
Apr 4 2017
,
Dec 21 2017
Very flaky on https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/ now. Encountered it here: https://chromium-review.googlesource.com/c/chromium/src/+/840142 I 382.381s run_tests_on_device(01e7d057cc773ed2) Error in testBasicValues(org.chromium.content.browser.ScreenOrientationListenerTest): I 382.381s run_tests_on_device(01e7d057cc773ed2) java.lang.AssertionError: expected:<3> but was:<1> I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.Assert.fail(Assert.java:88) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.Assert.failNotEquals(Assert.java:834) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.Assert.assertEquals(Assert.java:645) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.Assert.assertEquals(Assert.java:631) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.chromium.content.browser.ScreenOrientationListenerTest.testBasicValues(ScreenOrientationListenerTest.java:268) I 382.381s run_tests_on_device(01e7d057cc773ed2) at java.lang.reflect.Method.invoke(Native Method) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) I 382.381s run_tests_on_device(01e7d057cc773ed2) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) I 382.381s run_tests_on_device(01e7d057cc773ed2) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.rules.RunRules.evaluate(RunRules.java:20) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:184) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:41) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) I 382.381s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:166) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.Suite.runChild(Suite.java:128) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.Suite.runChild(Suite.java:27) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) I 382.382s run_tests_on_device(01e7d057cc773ed2) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) I 382.382s run_tests_on_device(01e7d057cc773ed2) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) I 382.382s run_tests_on_device(01e7d057cc773ed2) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:99) I 382.382s run_tests_on_device(01e7d057cc773ed2) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
,
Dec 22 2017
I think this is due to another test that was disabled.
,
Dec 24
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 7
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by gogerald@chromium.org
, Sep 9 2016