New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 708738

Blocking:
issue 609317



Sign in to add a comment
link

Issue 645602: Figure out sandboxing for mus-gpu

Reported by sadrul@chromium.org, Sep 9 2016 Project Member

Issue description

The mus gpu process needs to be sandboxed. But it also needs to do some initialization before the sandboxing happens. We need to add some mechanism to allow for a mojo app to do this.
 

Comment 1 by sadrul@chromium.org, Sep 14 2016

Cc: tsepez@chromium.org

Comment 2 by bugdroid1@chromium.org, Sep 20 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43aa4f706d6020c93f11fa952d7f1d7a7337c570

commit 43aa4f706d6020c93f11fa952d7f1d7a7337c570
Author: sadrul <sadrul@chromium.org>
Date: Tue Sep 20 23:11:51 2016

services/shell: Turn on sandboxing for mojo apps.

Turn on sandbox for mojo apps by default. Apps that need to run
without a sandbox need to include 'shell:unsandboxed' in their
capabilities in manifest for mojo:shell.

Update manifests for mojo:ui, mojo:font_service, mojo:file_system,
and mojo:leveldb services to include 'shell:unsandboxed'.

BUG=645602, 646376

Review-Url: https://codereview.chromium.org/2338793003
Cr-Commit-Position: refs/heads/master@{#419891}

[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/components/filesystem/manifest.json
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/components/font_service/manifest.json
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/components/leveldb/manifest.json
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/services/shell/service_manager.cc
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/services/ui/manifest.json

Comment 3 by bugdroid1@chromium.org, Sep 21 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b481c6d0540129abef93fb0279634ac4ab33a823

commit b481c6d0540129abef93fb0279634ac4ab33a823
Author: loyso <loyso@chromium.org>
Date: Wed Sep 21 01:08:02 2016

Revert of services/shell: Turn on sandboxing for mojo apps. (patchset #9 id:180001 of https://codereview.chromium.org/2338793003/ )

Reason for revert:
Causes a timeout on mash_browser_tests.

Original issue's description:
> services/shell: Turn on sandboxing for mojo apps.
>
> Turn on sandbox for mojo apps by default. Apps that need to run
> without a sandbox need to include 'shell:unsandboxed' in their
> capabilities in manifest for mojo:shell.
>
> Update manifests for mojo:ui, mojo:font_service, mojo:file_system,
> and mojo:leveldb services to include 'shell:unsandboxed'.
>
> BUG=645602, 646376
>
> Committed: https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570
> Cr-Commit-Position: refs/heads/master@{#419891}

TBR=rockot@chromium.org,ben@chromium.org,tsepez@chromium.org,sadrul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645602, 646376

Review-Url: https://codereview.chromium.org/2353783004
Cr-Commit-Position: refs/heads/master@{#419928}

[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/components/filesystem/manifest.json
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/components/font_service/manifest.json
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/components/leveldb/manifest.json
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/services/shell/service_manager.cc
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/services/ui/manifest.json

Comment 4 by fsam...@chromium.org, Dec 7 2016

Blocking: 609317

Comment 5 by fsam...@chromium.org, Dec 7 2016

Cc: piman@chromium.org jbau...@chromium.org

Comment 6 by sadrul@chromium.org, Dec 8 2016

Owner: sadrul@chromium.org
Status: Assigned (was: Available)
I will revive the CL I had landed for this: https://codereview.chromium.org/2338793003/

Comment 7 by sadrul@chromium.org, May 29 2017

Blockedon: 708738

Comment 8 by sky@chromium.org, Aug 13

Labels: Proj-Mash-MultiProcess

Comment 9 by jamescook@chromium.org, Aug 15

Labels: -Proj-Mustash-Mus-GPU
Cleaning up old Proj-Mustash labels.

Comment 10 by roc...@chromium.org, Oct 17

Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment