New issue
Advanced search Search tips

Issue 645597 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Wrong geometry of tspan following text node with a spaces

Reported by m...@mail.ru, Sep 9 2016 
UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

Steps to reproduce the problem:
1. http://codepen.io/djFD/full/NRGRXq
2. type something in the box supplied
3. done

What is the expected behavior?
The geometry in both cases need to be the same

What went wrong?
First text line has a spaces in its markup (text node, right before the tspan), and for that line tspan is broken somehow, while second line (markup is exactly the same, but without white spaces) works just a fine

Firefox, IE do handle this correct

Did this work before? N/A 

Chrome version: 52.0.2743.116 (Developer Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit)  Channel: stable
OS Version: Ubuntu 16.04 LTS
Flash Version: Shockwave Flash 11.2 r202

Comment 1 by dtapu...@chromium.org, Sep 9 2016

Components: -Blink Blink>Layout

Comment 2 by f...@opera.com, Sep 12 2016

Components: -Blink>Layout Blink>SVG
Labels: -OS-Linux
Status: Available (was: Unconfirmed)
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 12 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by f...@opera.com, Sep 12 2017

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Comment 5 by f...@opera.com, Sep 12 2017 

Attaching reduced TC. It looks like the linefeeds are what's causing the bug (maybe the text node is not properly re-normalized?)
issue-645597.html
378 bytes View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23eb4aecb98591f5ab0da65f14a7a970374b1f58

commit 23eb4aecb98591f5ab0da65f14a7a970374b1f58
Author: Fredrik Söderquist <fs@opera.com>
Date: Wed Sep 13 17:31:39 2017

Rework normalization in LayoutSVGInlineText

When performing (whitespace) normalization in an OriginalText override,
we miss normalization when the layout object has its text content
updated.
Perform the normalization in the SetTextInternal override instead to
cover the text-content-update case as well.

Bug:  645597 
Change-Id: Id65cbbe75dbcc636f4cde38b8bb8887d05caf1d7
Reviewed-on: https://chromium-review.googlesource.com/664812
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#501678}
[add] https://crrev.com/23eb4aecb98591f5ab0da65f14a7a970374b1f58/third_party/WebKit/LayoutTests/svg/text/text-positioning-mutate-textnode-2-expected.html
[add] https://crrev.com/23eb4aecb98591f5ab0da65f14a7a970374b1f58/third_party/WebKit/LayoutTests/svg/text/text-positioning-mutate-textnode-2.html
[modify] https://crrev.com/23eb4aecb98591f5ab0da65f14a7a970374b1f58/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
[modify] https://crrev.com/23eb4aecb98591f5ab0da65f14a7a970374b1f58/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

Comment 7 by f...@opera.com, Sep 14 2017

Owner: f...@opera.com
Status: Fixed (was: Available)
►

Sign in to add a comment