New issue
Advanced search Search tips

Issue 645591 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1777% regression in smoothness.top_25_smooth at 415045:415131

Project Member Reported by rsch...@chromium.org, Sep 9 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=645591

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgofqGpwkM


Bot(s) for this bug's original alert(s):

win-zenbook
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 10 2016

Cc: lanwei@chromium.org
Owner: lanwei@chromium.org

=== Auto-CCing suspected CL author lanwei@chromium.org ===

Hi lanwei@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Set the coordinates of the synthetic touch event correctly in SyntheticGestureTargetAura.
Author  : lanwei
Commit description:
  
In ConvertLocationToTarget function, the offset added to the event location is not scaled,
so we should apply the screen scale factor to the event location after it has been transformed to
the target. Then we can find the right target to send the event using the correct coordinates.

BUG=634343

Review-Url: https://codereview.chromium.org/2269483002
Cr-Commit-Position: refs/heads/master@{#415119}
Commit  : 34bff62e925142091ce98722c7bd447f51b3794b
Date    : Tue Aug 30 04:53:18 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@415044  8.2228   7.3304   5  good
chromium@415088  9.5792   7.11542  5  good
chromium@415110  6.164    4.15213  5  good
chromium@415116  8.493    4.69034  5  good
chromium@415118  5.9052   3.69515  5  good
chromium@415119  127.202  20.174   5  bad    <--
chromium@415121  195.83   121.177  5  bad
chromium@415131  159.269  80.7835  5  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 645591

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: first_gesture_scroll_update_latency/ESPN
Relative Change: 1836.92%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/472
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001970596299761456


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5193795656744960

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Sep 10 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Set the coordinates of the synthetic touch event correctly in SyntheticGestureTargetAura.
Author  : lanwei
Commit description:
  
In ConvertLocationToTarget function, the offset added to the event location is not scaled,
so we should apply the screen scale factor to the event location after it has been transformed to
the target. Then we can find the right target to send the event using the correct coordinates.

BUG=634343

Review-Url: https://codereview.chromium.org/2269483002
Cr-Commit-Position: refs/heads/master@{#415119}
Commit  : 34bff62e925142091ce98722c7bd447f51b3794b
Date    : Tue Aug 30 04:53:18 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@415044  3.9672   3.32144  5  good
chromium@415088  9.22925  8.66521  8  good
chromium@415110  11.9763  15.5088  8  good
chromium@415116  19.674   20.7856  8  good
chromium@415118  12.678   8.61545  5  good
chromium@415119  771.972  468.459  8  bad    <--
chromium@415121  688.389  545.887  8  bad
chromium@415131  318.048  379.512  5  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 645591

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: first_gesture_scroll_update_latency/ESPN
Relative Change: 7916.94%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/475
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001933218335938480


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6352960353730560

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Components: Blink>Input
lanwei, can you please take a look at this? It looks like you regressed this test pretty significantly.
lanwei, can you please take a look at this? It looks like you regressed this test pretty significantly.

Comment 8 by lanwei@chromium.org, Sep 12 2016

Status: Started (was: Assigned)
I am looking at this regression, thanks!
Weekly check in from the perf regression triage team, don't forget to update this bug if any progress is made towards improving this regression.
Status: WontFix (was: Started)
It is related to windows high-DPI issues. Oshima@ fixed the problem two days ago, and the regression is recovered now.

Sign in to add a comment