New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645538 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 646758



Sign in to add a comment

Discount for inactivity timeout for recording session length on desktop

Project Member Reported by gayane@chromium.org, Sep 9 2016

Issue description

Discount for inactivity timeout for recording session length on desktop.

Currently if user engagement session ends because of a inactivity timeout, the timeout length is counted within session length. It would be more accurate to discount for it.

 
Agreed, with the timeout being hit so much, we're probably heavily overestimating time spent
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9 2016

Status: Fixed (was: Assigned)

Comment 5 by gayane@chromium.org, Sep 13 2016

Status: Started (was: Fixed)
Reopening as the changes were reverted due to flaky unit test.

Details here:
https://bugs.chromium.org/p/chromium/issues/detail?id=645712
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2016

Comment 7 by yutak@chromium.org, Sep 14 2016

Blockedon: 646758
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68de0eb04f00eed4467bb743eccaec1b92dba132

commit 68de0eb04f00eed4467bb743eccaec1b92dba132
Author: gayane <gayane@chromium.org>
Date: Thu Sep 15 22:03:14 2016

Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG= 645538 ,  646758 

Review-Url: https://codereview.chromium.org/2344673002
Cr-Commit-Position: refs/heads/master@{#419000}

[modify] https://crrev.com/68de0eb04f00eed4467bb743eccaec1b92dba132/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc
[modify] https://crrev.com/68de0eb04f00eed4467bb743eccaec1b92dba132/tools/metrics/histograms/histograms.xml

Comment 9 by gayane@chromium.org, Sep 19 2016

Status: Fixed (was: Started)

Sign in to add a comment