New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645529 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Split base's proguard rules into app vs library

Project Member Reported by agrieve@chromium.org, Sep 9 2016

Issue description

Cronet would like to share the common chromium proguard flags for use in their proguard.flags that they include within their .aar. However, some of the flags within base_proguard_config.flags are application-wide and so not appropriate for a library to include.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a6f07769861e60b3346f94d1c09204d56604cc

commit 22a6f07769861e60b3346f94d1c09204d56604cc
Author: agrieve <agrieve@chromium.org>
Date: Fri Sep 09 19:18:02 2016

Remove unused proguard -keep for android.webkit.JavascriptInterface

Note: Verified that ChromePublic.apk has no change in size from
this change. Also verified with codesearch that the only thing
using android.webkit.JavaScriptInterface is
//android_webview/test:android_webview_test_apk,
which never enables proguard.

BUG= 645529 

Review-Url: https://codereview.chromium.org/2327883002
Cr-Commit-Position: refs/heads/master@{#417661}

[modify] https://crrev.com/22a6f07769861e60b3346f94d1c09204d56604cc/base/android/base_proguard_config.flags

Status: Fixed (was: Started)

Sign in to add a comment