New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645523 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 624262



Sign in to add a comment

wacom_flash displays fw version inconsistently in hex/decimal

Reported by charliemooney@chromium.org, Sep 9 2016

Issue description

The Wacom FW updater tool uses hex sometimes and decimal others when printing firmware versions which causes confusion with the FW updating scripts that use it.  We should fix this app so it only uses one way or the other -- decimal is probably easier.
 
Blocking: 624262
The merge request has been accepted on github.  I'll update the ebuild now to get the newest versions

https://github.com/flying-elephant/wacom_source/pull/17
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/75a2e7d14eea097617cce02609d34ad5ad1bd0b4

commit 75a2e7d14eea097617cce02609d34ad5ad1bd0b4
Author: Charlie Mooney <charliemooney@chromium.org>
Date: Mon Sep 12 16:28:19 2016

Update wacom_flash to us decimal versions only

This CL updates the version of wacom_flash that's being used
on ChromeOS to a one that only prints FW versions in decimal.
Previous hexidecimal was used in a few places which caused
issues when trying to interpret the output.

BUG= chromium:645523 
TEST=manually tested on a device with a Wacom touch IC

Change-Id: Ic7f418e60fdd28d9c7d6a71db6a17e1232f500a4
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/384335
Reviewed-by: Dennis Kempin <denniskempin@google.com>

[rename] https://crrev.com/75a2e7d14eea097617cce02609d34ad5ad1bd0b4/chromeos-base/wacom_fw_flash/wacom_fw_flash-1.1.4.ebuild
[modify] https://crrev.com/75a2e7d14eea097617cce02609d34ad5ad1bd0b4/chromeos-base/wacom_fw_flash/Manifest

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 6 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 28 2017

Labels: merge-merged-factory-reef-8811.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2d14c6cc2967009ee5aa9345079aeb4aeafc3091

commit 2d14c6cc2967009ee5aa9345079aeb4aeafc3091
Author: Charlie Mooney <charliemooney@chromium.org>
Date: Mon Sep 12 16:28:19 2016

Update wacom_flash to us decimal versions only

This CL updates the version of wacom_flash that's being used
on ChromeOS to a one that only prints FW versions in decimal.
Previous hexidecimal was used in a few places which caused
issues when trying to interpret the output.

BUG= chromium:645523 
TEST=manually tested on a device with a Wacom touch IC

Change-Id: Ic7f418e60fdd28d9c7d6a71db6a17e1232f500a4
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/384335
Reviewed-by: Dennis Kempin <denniskempin@google.com>
(cherry picked from commit 75a2e7d14eea097617cce02609d34ad5ad1bd0b4
Reviewed-on: https://chromium-review.googlesource.com/433499
Reviewed-by: YH Lin <yueherngl@chromium.org>
Commit-Queue: Keith Tzeng <keith.tzeng@quantatw.com>
Tested-by: Keith Tzeng <keith.tzeng@quantatw.com>

[rename] https://crrev.com/2d14c6cc2967009ee5aa9345079aeb4aeafc3091/chromeos-base/wacom_fw_flash/wacom_fw_flash-1.1.4.ebuild
[modify] https://crrev.com/2d14c6cc2967009ee5aa9345079aeb4aeafc3091/chromeos-base/wacom_fw_flash/Manifest

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)

Sign in to add a comment